Merge pull request #2 from DmitriiPetukhov/bugfix

Bugfixes
akvelon · Apr 21, 2023 · 91e99b3 · 91e99b3
2 parents 2c9693c + 681af95
commit 91e99b3
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 10 deletions.
diff --git a/package.json b/package.json
@@ -15,12 +15,12 @@
     "d3-selection": "3.0.0",
     "d3-shape": "3.2.0",
     "powerbi-visuals-api": "4.7.0",
-    "powerbi-visuals-utils-chartutils": "3.0.1",
-    "powerbi-visuals-utils-colorutils": "3.0.0",
+    "powerbi-visuals-utils-chartutils": "6.0.1",
+    "powerbi-visuals-utils-colorutils": "6.0.1",
     "powerbi-visuals-utils-dataviewutils": "2.4.1",
-    "powerbi-visuals-utils-formattingutils": "5.1.0",
-    "powerbi-visuals-utils-interactivityutils": "6.0.0",
-    "powerbi-visuals-utils-svgutils": "3.0.0",
+    "powerbi-visuals-utils-formattingutils": "6.0.1",
+    "powerbi-visuals-utils-interactivityutils": "6.0.2",
+    "powerbi-visuals-utils-svgutils": "6.0.1",
     "powerbi-visuals-utils-tooltiputils": "2.5.2"
   },
   "devDependencies": {
@@ -31,7 +31,7 @@
     "@types/d3-scale": "4.0.3",
     "@types/d3-selection": "3.0.4",
     "@types/d3-shape": "3.1.1",
-    "@typescript-eslint/eslint-plugin": "^5.54.1",
+    "@typescript-eslint/eslint-plugin": "5.57.0",
     "babel-loader": "9.1.2",
     "babel-plugin-module-resolver": "5.0.0",
     "base64-inline-loader": "2.0.1",

diff --git a/src/utilities/legendUtility.ts b/src/utilities/legendUtility.ts
@@ -147,9 +147,9 @@ function buildLegendData(
         for (let i: number = 0, len: number = grouped.length; i < len; i++) {
             const grouping = grouped[i];
 
-            const color = (grouping.objects && grouping.name && colorHelper.getColorForSeriesValue(
+            let color: string = colorHelper.getColorForSeriesValue(
                 grouping.objects,
-                grouping.name)) || undefined;
+                grouping.name);
 
             const selectionId: ISelectionId = host.createSelectionIdBuilder()
                 .withSeries(dataValues, grouping)
@@ -178,9 +178,9 @@ function buildLegendData(
                     const object = legendColumn.objects && legendColumn.objects.length > i
                         ? legendColumn.objects[i]
                         : null;
-                    const color = (object && colorHelper.getColorForSeriesValue(
+                    let color: string = colorHelper.getColorForSeriesValue(
                         object,
-                        name)) || undefined;
+                        name);
 
                     const selectionId: ISelectionId = host.createSelectionIdBuilder()
                         .withCategory(legendColumn, i)