feat(directives): optional images for kustomize-set-image
#3115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-kargo-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
hiddeco
force-pushed
the
kus-update-optional-img
branch
from
6fd1413 to
bad0e65
Compare
Signed-off-by: Hidde Beydals <[email protected]>
Signed-off-by: Hidde Beydals <[email protected]>
Signed-off-by: Hidde Beydals <[email protected]>
Signed-off-by: Hidde Beydals <[email protected]>
hiddeco
force-pushed
the
kus-update-optional-img
branch
from
3b0bc5a to
654d234
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3115 +/- ##
==========================================
+ Coverage 51.14% 51.26% +0.11%
==========================================
Files 283 283
Lines 25474 25563 +89
==========================================
+ Hits 13028 13104 +76
- Misses 11752 11762 +10
- Partials 694 697 +3 ☔ View full report in Codecov by Sentry. |
krancour
reviewed
Dec 10, 2024
Signed-off-by: Hidde Beydals <[email protected]>
hiddeco
force-pushed
the
kus-update-optional-img
branch
from
654d234 to
4462a6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this pull request, setting
imagesfor thekustomize-set-imagestep is now optional.When left unspecified, all images from the Freight collection are automatically set as long as there is no ambiguous target image found (due to e.g. two Warehouses having different selectors for the same image). In case of an ambiguous target image, an error is returned and manual configuration of
imageswill still be required.It is worth noting that the generated commit message describes what's being set in the
kustomization.yaml, and will thus contain a reference to all images even if they do not appear in any of the Kubernetes manifests which are part of the Kustomization overlay.Fixes: #2788