feat: add promotion step to remove a file/directory

[nitishfy]

Fixes #2860

[netlify]

✅ Deploy Preview for docs-kargo-io ready!

Name	Link
🔨 Latest commit	c013076
🔍 Latest deploy log	https://app.netlify.com/sites/docs-kargo-io/deploys/6760397521ab9c0008291a8a
😎 Deploy Preview	https://deploy-preview-3086.docs.kargo.io
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[codecov]

Codecov Report

Attention: Patch coverage is 61.53846% with 15 lines in your changes missing coverage. Please review.

Project coverage is 51.22%. Comparing base (404422a) to head (9866605).

Files with missing lines	Patch %	Lines
internal/directives/file_deleter.go	61.53%	14 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3086      +/-   ##
==========================================
+ Coverage   51.20%   51.22%   +0.01%     
==========================================
  Files         283      284       +1     
  Lines       25466    25505      +39     
==========================================
+ Hits        13041    13065      +24     
- Misses      11729    11743      +14     
- Partials      696      697       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[hiddeco]

In addition to these tests, can you add:

• One which removes a symlink (should remove the literal symlink, and not the file).
• One which removes a file or directory within a symlink (should traverse into the symlink and remove it).

[krancour]

This needs docs.

[krancour]

@nitishfy we're looking to have 1.2 work done by 12/20 with plans to release after the winter break. Are you able to implement feedback before then?

[nitishfy]

Suggested change

	name: "removes symlink only",
	name: "removes symlink only",

@hiddeco I tried debugging to understand why is this test case failing even though the path specified is correct. After debugging i found that, SecureJoin() is actually joining the file input/input.txt that is linked by the symlink.txt instead of joining the file symlink.txt, Following is the error message

=== RUN   Test_fileDeleter_runPromotionStep
--- FAIL: Test_fileDeleter_runPromotionStep (120.72s)
=== RUN   Test_fileDeleter_runPromotionStep/removes_symlink_only
path to delete: /tmp/Test_fileDeleter_runPromotionStepremoves_symlink_only1504252788/001/input/input.txt
    file_deleter_test.go:100: 
        	Error Trace:	/home/nitish/Documents/Work/Open-Source/kargo/internal/directives/file_deleter_test.go:100
        	            				/home/nitish/Documents/Work/Open-Source/kargo/internal/directives/file_deleter_test.go:115
        	Error:      	Received unexpected error:
        	            	stat /tmp/Test_fileDeleter_runPromotionStepremoves_symlink_only1504252788/001/input.txt: no such file or directory
        	Test:       	Test_fileDeleter_runPromotionStep/removes_symlink_only
    --- FAIL: Test_fileDeleter_runPromotionStep/removes_symlink_only (120.72s)

[nitishfy]

cc @hiddeco PTAL

[nitishfy]

@nitishfy we're looking to have 1.2 work done by 12/20 with plans to release after the winter break. Are you able to implement feedback before then?

Yes. The failing test case is the only blockage so far, once the CI checks are running I'll add the docs.