feat(verification): improve transient error handling #1650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-kargo-akuity-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1650 +/- ##
==========================================
+ Coverage 44.04% 44.19% +0.14%
==========================================
Files 207 208 +1
Lines 13133 13168 +35
==========================================
+ Hits 5784 5819 +35
Misses 7106 7106
Partials 243 243 ☔ View full report in Codecov by Sentry. |
hiddeco
changed the title
|
This LGTM after merge conflicts are resolved. I may be PR'ing something similar for Promotions shortly. |
hiddeco
force-pushed
the
imprv-transient-err-handling
branch
from
01c4bbf to
d566baa
Compare
|
Has been rebased. |
hiddeco
force-pushed
the
imprv-transient-err-handling
branch
from
d566baa to
b7903a2
Compare
krancour
approved these changes
Apr 9, 2024
This commit improves the handling of transient Kubernetes API errors which may occur during the verification step of a Stage's current Freight. It does this by selectively returning errors which should be retried, causing the reconciler to not leave the `Verifying` phase and allowing it to retry the action it performed on the next reconciliation attempt. To allow the reconciler to distinguish a creation error from a failed attempt to retrieve results, closer inspection is performed on the existence of an `AnalysisRun` reference in the `VerificationInfo`. Signed-off-by: Hidde Beydals <[email protected]>
hiddeco
force-pushed
the
imprv-transient-err-handling
branch
from
b7903a2 to
f673374
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses (part of) #1640
This improves the handling of transient Kubernetes API errors which may occur during the verification step of a Stage's current Freight.
It does this by selectively returning errors which should be retried, causing the reconciler to not leave the
Verifyingphase and allowing it to retry the action it performed on the next reconciliation attempt.To allow the reconciler to distinguish a creation error from a failed attempt to retrieve results, closer inspection is performed on the existence of an
AnalysisRunreference in theVerificationInfo.