Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distinguish permanent API errors from transient ones #1640

Open
hiddeco opened this issue Mar 15, 2024 · 3 comments
Open

Distinguish permanent API errors from transient ones #1640

hiddeco opened this issue Mar 15, 2024 · 3 comments

Comments

@hiddeco
Copy link
Contributor

hiddeco commented Mar 15, 2024

We do at present not distinguish "not found" errors (permanent) from e.g. "the Kubernetes API server temporary can not be reached" (transient). Because of this, a Stage's verification process may fail prematurely while the controller could theoretically automatically recover it, if given the time.

As manually recovering from it is both cumbersome to a user, and potentially a waste of computing power used by the AnalysisRun. I think we can do a better job at distinguishing these type of errors, and prevent giving up on transient ones by e.g. requeueing and not erasing AnalysisRun references, etc.

xref: #1611 (comment)


Note: While I have only observed this to happen for a Stage's verification process, this may actually apply to more areas of Kargo.

@krancour
Copy link
Member

I think we've made progress on this and there's more to be made still, but I think that, like #1479, this is an on-going effort that we can kick from release to release until we feel satisfied.

@krancour krancour added this to the v0.9.0 milestone Aug 19, 2024
@krancour krancour modified the milestones: v0.9.0, v0.10.0 Sep 30, 2024
@krancour
Copy link
Member

Deferring as this is something we're just tracking until satisfied.

@krancour krancour modified the milestones: v1.0.0, v1.1.0 Oct 12, 2024
@krancour krancour modified the milestones: v1.1.0, v1.2.0 Nov 15, 2024
@krancour krancour modified the milestones: v1.2.0, v1.3.0 Dec 12, 2024
@krancour
Copy link
Member

Noting some incremental progress on this in #3119

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants