-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MySQL implementation #803
Add MySQL implementation #803
Conversation
Hi @steventwheeler, Thank you for your contribution! We really value the time you've taken to put this together. Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement: |
I'm working on getting the CLA approved on my end but this change appears to resolve the issues I was seeing in my application. |
Hi @steventwheeler, Thank you for your contribution! We really value the time you've taken to put this together. Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement: |
My employer has signed the CLA. |
Thanks for your contribution @steventwheeler. However, for the CLA, the one that contributed needs to sign. The CLA checker will verify if user |
So, what I'm saying is, if you have their authorization to contribute code to Akka, then you can sign the CLA and the code can be accepted by Lightbend. |
I have signed it as well. |
Or at least I linked my GitHub account to your site and filled in the form. Is there another step that is required? |
I manually verified there is an entry in the CLA database 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
closing and reopen to re-trigger the CLA check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @steventwheeler for the contribution.
Hey @steventwheeler, unfortunately we had an issue with the CI setup and didn't notice that the |
This reverts commit 98710d8.
@johanandren Seems like MySQL can only increase the sequence by inserting and from the database itself. I will say the Oracle and SQLServer will be more easy to implement. Need some magic tricks that make MySQL work. |
References #802