Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MySQL implementation #803

Merged

Conversation

steventwheeler
Copy link
Contributor

References #802

@lightbend-cla-validator
Copy link

Hi @steventwheeler,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:

http://www.lightbend.com/contribute/cla

@steventwheeler
Copy link
Contributor Author

I'm working on getting the CLA approved on my end but this change appears to resolve the issues I was seeing in my application.

@lightbend-cla-validator
Copy link

Hi @steventwheeler,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:

http://www.lightbend.com/contribute/cla

@steventwheeler
Copy link
Contributor Author

My employer has signed the CLA.

@octonato
Copy link
Member

octonato commented Mar 8, 2024

My employer has signed the CLA.

Thanks for your contribution @steventwheeler.

However, for the CLA, the one that contributed needs to sign. The CLA checker will verify if user @steventwheeler has signed.

@octonato
Copy link
Member

octonato commented Mar 8, 2024

My employer has signed the CLA.

Thanks for your contribution @steventwheeler.

However, for the CLA, the one that contributed needs to sign. The CLA checker will verify if user @steventwheeler has signed.

So, what I'm saying is, if you have their authorization to contribute code to Akka, then you can sign the CLA and the code can be accepted by Lightbend.

@steventwheeler
Copy link
Contributor Author

My employer has signed the CLA.

Thanks for your contribution @steventwheeler.
However, for the CLA, the one that contributed needs to sign. The CLA checker will verify if user @steventwheeler has signed.

So, what I'm saying is, if you have their authorization to contribute code to Akka, then you can sign the CLA and the code can be accepted by Lightbend.

I have signed it as well.

@steventwheeler
Copy link
Contributor Author

Or at least I linked my GitHub account to your site and filled in the form. Is there another step that is required?

@johanandren
Copy link
Member

I manually verified there is an entry in the CLA database 👍

Copy link
Member

@johanandren johanandren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@octonato
Copy link
Member

closing and reopen to re-trigger the CLA check

@octonato octonato closed this Mar 11, 2024
@octonato octonato reopened this Mar 11, 2024
Copy link
Member

@octonato octonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks @steventwheeler for the contribution.

@octonato octonato merged commit 98710d8 into akka:master Mar 11, 2024
27 checks passed
@steventwheeler steventwheeler deleted the 802-incomplete-mysql-implementation branch March 11, 2024 13:42
@johanandren
Copy link
Member

Hey @steventwheeler, unfortunately we had an issue with the CI setup and didn't notice that the MySQLScalaJdbcDurableStateChangesByTagTest doesn't pass from this PR, I've disabled it in #806 where I fix the CI jobs, would be great if you could take a look, seems like the MySQLSequenceNextValUpdater doesn't work as expected.

johanandren added a commit that referenced this pull request Mar 14, 2024
johanandren added a commit that referenced this pull request Mar 21, 2024
@Roiocam
Copy link
Contributor

Roiocam commented Apr 4, 2024

Hey @steventwheeler, unfortunately we had an issue with the CI setup and didn't notice that the MySQLScalaJdbcDurableStateChangesByTagTest doesn't pass from this PR, I've disabled it in #806 where I fix the CI jobs, would be great if you could take a look, seems like the MySQLSequenceNextValUpdater doesn't work as expected.

@johanandren Seems like MySQL can only increase the sequence by inserting and from the database itself. I will say the Oracle and SQLServer will be more easy to implement. Need some magic tricks that make MySQL work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants