fix: flaky CurrentEventsByTagTest #783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI check passed, close and reopn PR to trigger CI check run again. |
Roiocam
commented
Nov 1, 2023
| @@ -191,6 +203,8 @@ abstract class CurrentEventsByTagTest(config: String) extends QueryTestSpec(conf | |||
|
|
|||
| // start the query before the last batch completes | |||
| journalOps.withCurrentEventsByTag()(tag, NoOffset) { tp => | |||
| // when query begin running, unlock the barrier. | |||
| latch.countDown() | |||
| // The stream must complete within the given amount of time | |||
| // This make take a while in case the journal sequence actor detects gaps | |||
| val allEvents = tp.toStrict(atMost = 20.seconds) | |||
There was a problem hiding this comment.
The flaky/unstable assert on here, It depends on the execution speed.
Roiocam
commented
Nov 10, 2023
|
|
||
| // wait for acknowledgement of the first batch only | ||
| batch1.futureValue | ||
| // Sanity check, all events in the first batch must be in the journal | ||
| journalOps.countJournal.futureValue should be >= 600L | ||
|
|
||
| // Try to persist a large batch of events per actor. Some of these may be returned, but not all! | ||
| val batch2 = sendMessagesWithTag(tag, 5000) |
There was a problem hiding this comment.
looks like this reordering works, CI check passed twice, trigger check again.
ennru
approved these changes
Mar 25, 2024
ennru
force-pushed
the
flaky-intergration-tests
branch
from
9b64693 to
9c8b5a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References #782
Delay persistence to the start of the query