perf: Reducing memory cost while replaying #765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanandren
requested changes
Sep 14, 2023
| @@ -118,7 +118,7 @@ class JdbcAsyncWriteJournal(config: Config) extends AsyncWriteJournal { | |||
| journalDao | |||
| .messagesWithBatch(persistenceId, fromSequenceNr, toSequenceNr, journalConfig.daoConfig.replayBatchSize, None) | |||
| .take(max) | |||
| .mapAsync(1)(reprAndOrdNr => Future.fromTry(reprAndOrdNr)) | |||
| .collect { case Success(reprAndOrdNr) => reprAndOrdNr } | |||
There was a problem hiding this comment.
This has different behaviour than the original logic though, that would fail the stream on a Failure while this filters it out. Better would be to skip this operator/step completely and do the match in runForEach and throw for Failure there:
.runForeach {
case Success((repr, _)) =>
recoveryCallback(repr)
case Failure(ex) => throw ex
}There was a problem hiding this comment.
More effiency, Yay!
[info] Benchmark Mode Cnt Score Error Units
[info] JdbcAsyncJournalBenchmark.originalAsync thrpt 3 581405.864 ± 217516.676 ops/s
[info] JdbcAsyncJournalBenchmark.streamWithCollect thrpt 3 594420.619 ± 29680.962 ops/s
[info] Benchmark Mode Cnt Score Error Units
[info] JdbcAsyncJournalBenchmark.originalAsync thrpt 3 577291.504 ± 51386.930 ops/s
[info] JdbcAsyncJournalBenchmark.streamWithCollect thrpt 3 605493.214 ± 4152.262 ops/s
There was a problem hiding this comment.
Push my commit again, because i havn't permission to apply this request change,
Roiocam
force-pushed
the
roiocam-less-mem-cost
branch
from
272e013 to
9cbe433
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No References.
Motivation:
Reducing memory cost on replaying query stream
Result
Additional bonus: slight performance improvement.
JMH for this change: https://gist.github.com/Roiocam/aabbf404aa2e1a4e967967e450b0def0