-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(observability): utilise new logger in stats-web #462
Conversation
would you check this pr? @ygrishajev |
all things are completed @ygrishajev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so how does it work with process.env and config within logger?
how about now? @ygrishajev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so I have LOG_LEVEL=debug
but it's not picked up by config in the browser. I think config needs to be provided to the LoggerService constructor.
i am not sure what this meaning exactly |
@forbesus LOG_LEVEL is an env var LOG_LEVEL: z.enum(["fatal", "error", "warn", "info", "debug", "trace"]).optional().default("info"), which controls which logs are done. It is a great way to configure logger on the backend, but it wouldn't work in most frontend implementations. So LoggerService should probably implement both env vars and config object as param in constructor. |
how about now? @ygrishajev |
please check again @ygrishajev |
how about now? @ygrishajev |
4eb278d
to
2911dc2
Compare
cca35e3
to
7c994da
Compare
hello @ygrishajev i just fixed this issue |
@forbesus I'm getting this error on the backend
|
4d070b7
to
0d9930a
Compare
0d9930a
to
094beaa
Compare
094beaa
to
6f5fa22
Compare
moved to #516 |
ref #436