feat(env): implement unified file loading in console-web #355
Conversation
ygrishajev
force-pushed
the
feature/env
branch
2 times, most recently
from
80be547 to
0f940c6
Compare
| @@ -0,0 +1,13 @@ | |||
| export async function register() { | |||
There was a problem hiding this comment.
this is how we can run validation once on server start up
There was a problem hiding this comment.
| @@ -10,6 +10,16 @@ const withPWA = require("next-pwa")({ | |||
| }); | |||
| const { withSentryConfig } = require("@sentry/nextjs"); | |||
|
|
|||
| try { | |||
| const { browserEnvSchema } = require("./env-config.schema"); | |||
There was a problem hiding this comment.
this file is compiled as a part of a build npm script. So it is expected to only be present at docker build time. Or anytime the command is executed off
ygrishajev
force-pushed
the
feature/env
branch
from
0f940c6 to
20ebd93
Compare
| AUTH0_CLIENT_ID: z.string(), | ||
| AUTH0_CLIENT_SECRET: z.string(), | ||
| AUTH0_AUDIENCE: z.string(), | ||
| AUTH0_SCOPE: z.string() |
There was a problem hiding this comment.
I have AUTH0_M2M_DOMAIN, AUTH0_M2M_CLIENT_ID and AUTH0_M2M_CLIENT_SECRET locally, do we need them? @Redm4x
There was a problem hiding this comment.
can't find not where they used, nor here https://auth0.github.io/nextjs-auth0/types/config.ConfigParameters.html
are they needed? seems like it all works without them
There was a problem hiding this comment.
wait a min, found them
There was a problem hiding this comment.
but again, they are not set in prod or staging. Are the needed?
| @@ -0,0 +1,13 @@ | |||
| export async function register() { | |||
There was a problem hiding this comment.
ygrishajev
force-pushed
the
feature/env
branch
from
20ebd93 to
2019fa2
Compare
refs #313