fix file descriptor leak in example http server code #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @ajyoon, just a friendly ping on this :) |
ajyoon
reviewed
May 11, 2022
Comment on lines
+561
to
+567
| Move to cell 51 | ||
| >>> | ||
|
|
||
| Close the opened file | ||
|
|
||
| The current cell is 49 | ||
| The source file descriptor is in cell 53 |
There was a problem hiding this comment.
The comment above says it moves to cell 51, but this comment here says it's 49?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally the code only closed the fd for the connection but not for the file.
I'm running this code in prod and it ran out of fds fairly quickly. This fix makes it more stable :)