Upgrade to Python 3 and Django 2 #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overlay plots are now generated with matplotlib and not aplpy. This dramatically increases speed on python 2 (python 3 aplpy is faster). Tried to mimic aplpy plots as much as possible. Next step is to address postage stamps.
The overview query table now includes the ASKAP non-convolved integrated flux density when downloading the CSV. It does not show on the main page still.
* Changed name to 'racstransients'. * Fixed migrations on website. * Started to convert to Python 3 (incomplete).
* Further Python 3 updates. * Make use of Cutout2D from astropy. * Making NVSS work.
ajstewart
added
enhancement
* Pipeline runs to completion. * Added ASKAP logo. * Tested NVSS image only.
* Fixed pipeline convolving with CASA. * Added switch on default aladin HiPS.
* Working postage stamps using matplotlib. * Need to filter ellipse catalogue first in next commit. * Fixed aegean reading of pre-conv catalogue.
Able to see edge of image.
* Postage stamps with matplotlib now include the text overlays. * Fixed postage stamp issues for non-convolved runs. * Updated settings template.
* Select number of cores. * Select the radius of the cutouts.
* Switched good matches check to using an apply function on the df. Will update others next. * Fixed postage stamp crash with non-convolve dataframe.
* Made the base mosaic value decoded. * Added a check on the ASKAP only sources that it has a non-convolved match. * Removed commented code.
* Put flags in to deal with no transient detections. * Fixed SUMSS subplot size (due to non square pixels).
Mosaic name was being injected into database as a byte string. Never could get to the root cause but this fixes the database inject.
Faster to slice the array directly.
* Bug in this commit of 0.0 value for integrated ASKAP flux. Need to fix.
* 0 case was caused by aegean local rms coming back as 0. * Fixed edge check. * Fixed sorting of dictionary in python3.
|
This is now ready with multiple successful runs with both SUMSS and NVSS and a working website. There will absolutely be other bugs that linger but they will have to be found through further testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update will make the pipeline compatible with Python 3.
Will also include matplotlib upgrade,
nvss-onlymode and a name change toracstransients.Fixes #73 and half of #71
Fixes #63.