Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: display project_vpc_id computed on plan #1948

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

byashimov
Copy link
Contributor

@byashimov byashimov commented Dec 17, 2024

When project_vpc_id is not assigned, it is set automatically on the backend. The change adds the same functionality on the client side to display it in the plan.

Type: schema.TypeString,
Optional: true,
Computed: true,
Description: "Specifies the VPC the service should run in. If the value is not set the service is not run inside a VPC. When set, the value should be given as a reference to set up dependencies correctly and the VPC must be in the same cloud and region as the service itself. Project can be freely moved to and from VPC after creation but doing so triggers migration to new servers so the operation can take significant amount of time to complete if the service has a lot of data.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about:

The ID of the the aiven_project_vpc to deploy the service in. If not set, the service is automatically deployed in a VPC when that project has only one VPC. To avoid this, set the value to null. You can move the service to a different VPC after creation. This migration can take some time to complete if the service has a lot of data.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like that ^ is not accurate based on internal discussions? So maybe it should be:

The ID of the the aiven_project_vpc to deploy the service in. If not set, the service is automatically deployed in a VPC when that project has only one VPC. You can move the service to a different VPC after creation. This migration can take some time to complete if the service has a lot of data.

Let me know if other changes are needed. 🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants