Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(lint): add errorlint #1561

Merged
merged 1 commit into from
Jan 26, 2024
Merged

ci(lint): add errorlint #1561

merged 1 commit into from
Jan 26, 2024

Conversation

rominf
Copy link
Contributor

@rominf rominf commented Jan 26, 2024

About this change—what it does

Add https://github.com/polyfloyd/go-errorlint to find code that will cause problems with Go's error wrapping scheme.

This is partial implementation of #858.

Why this way

Implementation is based on recommendations from https://pkg.go.dev/errors.

@rominf rominf added the no changelog No changelog entries are required for this PR label Jan 26, 2024
@rominf rominf marked this pull request as ready for review January 26, 2024 09:53
@rominf rominf requested a review from a team January 26, 2024 09:53
@Serpentiel Serpentiel self-assigned this Jan 26, 2024
Copy link
Contributor

@Serpentiel Serpentiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Add https://github.com/polyfloyd/go-errorlint to find code that will
cause problems with Go's error wrapping scheme.

This is partial implementation of aiven#858.
@Serpentiel Serpentiel enabled auto-merge (squash) January 26, 2024 12:19
@Serpentiel Serpentiel merged commit 589a638 into aiven:main Jan 26, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog No changelog entries are required for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants