Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(flink): add pre deletion check #1550

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Conversation

ivan-savciuc
Copy link
Contributor

About this change—what it does

Add Flink service deletion check, it is impossible to delete a Flink service if we have active Deployments with Jobs that are managed outside of Terraform via Web UI. Expectation is that users clean up all the running Jobs via Web UI and remove all deployments prior to deletion of Flink service.

@ivan-savciuc ivan-savciuc requested a review from a team January 23, 2024 05:51
Copy link
Contributor

@Serpentiel Serpentiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Serpentiel Serpentiel self-assigned this Jan 23, 2024
@Serpentiel Serpentiel added the enhancement New feature or request label Jan 23, 2024
@Serpentiel Serpentiel enabled auto-merge (squash) January 23, 2024 07:22
@Serpentiel Serpentiel force-pushed the ivans-add-flink-deletion-check branch from 0c04582 to 0e819f2 Compare January 23, 2024 07:23
@Serpentiel Serpentiel merged commit 6c8c990 into main Jan 23, 2024
10 checks passed
@Serpentiel Serpentiel deleted the ivans-add-flink-deletion-check branch January 23, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants