Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(test): proper concurrency support #1472

Merged
merged 1 commit into from
Dec 18, 2023
Merged

ci(test): proper concurrency support #1472

merged 1 commit into from
Dec 18, 2023

Conversation

Serpentiel
Copy link
Contributor

@Serpentiel Serpentiel commented Dec 11, 2023 •
edited
Loading

About this change—what it does

adds proper concurrency support for acctest and examples test CI, allowing to run multiple tests for multiple different branches at once

Why this way

it's good, really good, amazing, wonderful

@Serpentiel Serpentiel added enhancement New feature or request no changelog No changelog entries are required for this PR labels Dec 11, 2023
@Serpentiel Serpentiel requested a review from a team December 11, 2023 14:22
@Serpentiel Serpentiel force-pushed the aleks-ci-acctest-proper-concurrency-support branch 3 times, most recently from 567a29e to 6254d04 Compare December 12, 2023 18:15
@Serpentiel Serpentiel force-pushed the aleks-ci-acctest-proper-concurrency-support branch from 6254d04 to 43678bd Compare December 13, 2023 11:44
@Serpentiel Serpentiel requested a review from byashimov December 13, 2023 11:44
byashimov
byashimov requested changes Dec 14, 2023
View reviewed changes
.github/workflows/test/acceptance-tests/setup_aiven_project.sh Outdated Show resolved Hide resolved
.github/workflows/test/acceptance-tests/setup_aiven_project.sh Outdated Show resolved Hide resolved
.github/workflows/test/acceptance-tests/README.md Outdated Show resolved Hide resolved
.github/workflows/test/run_tests.sh Outdated Show resolved Hide resolved
@Serpentiel Serpentiel force-pushed the aleks-ci-acctest-proper-concurrency-support branch from 43678bd to 65c4cba Compare December 14, 2023 11:18
Serpentiel
Serpentiel commented Dec 14, 2023
View reviewed changes
go.mod Show resolved Hide resolved
@Serpentiel Serpentiel requested a review from byashimov December 14, 2023 11:20
@Serpentiel Serpentiel changed the title ci(acctest): proper concurrency support ci(test): proper concurrency support Dec 14, 2023
@Serpentiel Serpentiel force-pushed the aleks-ci-acctest-proper-concurrency-support branch 2 times, most recently from 3de2ccd to fcc5aab Compare December 14, 2023 11:34
@Serpentiel Serpentiel marked this pull request as draft December 14, 2023 11:49
@Serpentiel Serpentiel force-pushed the aleks-ci-acctest-proper-concurrency-support branch from fcc5aab to 1eedede Compare December 14, 2023 12:15
@Serpentiel Serpentiel marked this pull request as ready for review December 14, 2023 12:15
@Serpentiel Serpentiel force-pushed the aleks-ci-acctest-proper-concurrency-support branch 7 times, most recently from 483effa to 4f906c7 Compare December 14, 2023 12:58
byashimov
byashimov requested changes Dec 15, 2023
View reviewed changes
Copy link
Contributor

@byashimov byashimov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v2 client is not released. Otherwise lgtm

byashimov
byashimov previously approved these changes Dec 15, 2023
View reviewed changes
Copy link
Contributor

@byashimov byashimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Serpentiel Serpentiel force-pushed the aleks-ci-acctest-proper-concurrency-support branch from 4f906c7 to 7735f22 Compare December 15, 2023 13:26
@Serpentiel Serpentiel requested review from a team and byashimov December 15, 2023 13:26
@Serpentiel Serpentiel force-pushed the aleks-ci-acctest-proper-concurrency-support branch from 7735f22 to 9c6318d Compare December 16, 2023 01:23
@Serpentiel Serpentiel force-pushed the aleks-ci-acctest-proper-concurrency-support branch from 9c6318d to 125b202 Compare December 18, 2023 08:41
ivan-savciuc
ivan-savciuc approved these changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@ivan-savciuc ivan-savciuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ivan-savciuc ivan-savciuc merged commit 844d0b7 into main Dec 18, 2023
9 checks passed
@ivan-savciuc ivan-savciuc deleted the aleks-ci-acctest-proper-concurrency-support branch December 18, 2023 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivan-savciuc ivan-savciuc ivan-savciuc approved these changes

@byashimov byashimov Awaiting requested review from byashimov

Assignees

@ivan-savciuc ivan-savciuc

Labels
enhancement New feature or request no changelog No changelog entries are required for this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Serpentiel @byashimov @ivan-savciuc