feat(kafkatopic): creation simplification #1357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivan-savciuc
added
the
no changelog
Serpentiel
force-pushed
the
ivans-kafka-topic-create-simplifications
branch
from
2bc6bf4 to
0fe89f6
Compare
ivan-savciuc
force-pushed
the
ivans-kafka-topic-create-simplifications
branch
from
0fe89f6 to
a6676d5
Compare
Serpentiel
previously approved these changes
Sep 18, 2023
Serpentiel
force-pushed
the
ivans-kafka-topic-create-simplifications
branch
from
a6676d5 to
daa9322
Compare
|
Tests are still failing, lets catch up to discuss this issue. |
byashimov
previously requested changes
Sep 18, 2023
byashimov
reviewed
Sep 18, 2023
ivan-savciuc
force-pushed
the
ivans-kafka-topic-create-simplifications
branch
from
daa9322 to
d412c03
Compare
ivan-savciuc
dismissed
byashimov’s stale review
deleted all the cache invalidation changes out from this PR
ivan-savciuc
force-pushed
the
ivans-kafka-topic-create-simplifications
branch
from
d412c03 to
a3191a3
Compare
ivan-savciuc
force-pushed
the
ivans-kafka-topic-create-simplifications
branch
from
a3191a3 to
876143e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this change—what it does
we already have retry logic in the client no need for the retry logic in the TF and fixes acceptance tests