Remove Multidex usages

[MGaetan89]

Since the min SDK is 26, it is no longer necessary to use the Multidex library.

See the following for more info: https://developer.android.com/build/multidex#mdex-on-l

Summary by CodeRabbit

• New Features

  • Simplified application structure by removing multi-dex support, enhancing build efficiency.

• Bug Fixes

  • Resolved potential issues related to multi-dexing by transitioning to a standard application class.

• Chores

  • Updated dependency management for a more streamlined build process in line with modern Android practices.

[coderabbitai]

Walkthrough

The changes involve modifications to the app/build.gradle file and the App class within the application. In the build.gradle, the multiDexEnabled property and dependencies related to MultiDex have been removed, indicating a shift away from multi-dex support. In the App class, the superclass has been changed from MultiDexApplication to Application, further simplifying the application structure and eliminating multidexing support.

Changes

File Path	Change Summary
app/build.gradle	Removed multiDexEnabled from defaultConfig; removed testImplementation "org.robolectric:shadows-multidex:$robolectricVersion"; removed implementation "androidx.multidex:multidex:$multidexVersion"
app/src/main/kotlin/com/ivanovsky/passnotes/App.kt	Changed superclass from MultiDexApplication to Application; updated import statements accordingly.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant App
    participant SettingsImpl
    participant LoggerInteractor
    participant Koin

    User->>App: Launch Application
    App->>SettingsImpl: Initialize Settings
    App->>LoggerInteractor: Initialize Logger
    App->>Koin: Setup Dependency Injection

Loading

🐇 "In the code, we hop and play,
No more MultiDex, hip-hip-hooray!
Dependencies trimmed, clean and bright,
Our app now dances in the light!
With every change, we leap with glee,
A simpler path for you and me!" 🐇

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 870d2f4 and dd7c6e1.

📒 Files selected for processing (2)

• app/build.gradle (0 hunks)
• app/src/main/kotlin/com/ivanovsky/passnotes/App.kt (2 hunks)

💤 Files with no reviewable changes (1)

• app/build.gradle

🧰 Additional context used

🔇 Additional comments (3)

app/src/main/kotlin/com/ivanovsky/passnotes/App.kt (3)

3-3: LGTM: Import statement updated correctly.

The import statement has been updated to use android.app.Application instead of MultiDexApplication. This change aligns with the PR objective of removing Multidex usage.

---

Line range hint 1-50: Summary: Multidex removal successfully implemented.

The changes in this file effectively remove the Multidex usage from the App class. The superclass has been changed from MultiDexApplication to Application, and the corresponding import has been updated. These modifications align perfectly with the PR objective of removing Multidex usage due to the updated minimum SDK version.

The rest of the App class implementation remains unchanged, which is appropriate as the Multidex removal doesn't require any other modifications in this context. The onCreate method and other class members are unaffected, preserving the existing application initialization logic.

These changes contribute to streamlining the project by removing unnecessary dependencies, as intended by the PR.

---

14-14: LGTM: Class declaration updated correctly.

The App class now extends Application instead of MultiDexApplication, which aligns with the PR objective of removing Multidex usage. The open modifier is correctly retained, preserving the class's extensibility.

To ensure this change doesn't have unintended consequences, let's verify that there are no remaining references to MultiDexApplication in the codebase:

✅ Verification successful

Verified: No remaining references to MultiDexApplication or multidex configurations found.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for any remaining references to MultiDexApplication

# Test: Search for MultiDexApplication usage
echo "Searching for MultiDexApplication references:"
rg --type kotlin --type gradle "MultiDexApplication"

# Test: Confirm that multidex is removed from build.gradle
echo "Checking build.gradle for multidex configurations:"
rg --type gradle "multiDexEnabled|com.android.support:multidex"

Length of output: 330

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[aivanovski]

Hey @MGaetan89,
Thank you for this PR and information about multidex. I will try to figure out what is going wrong with CI build and merge it after that.