Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Support externally defined benchmark plugins #36

Merged
merged 2 commits into from
Feb 2, 2024

Conversation

HaoZeke
Copy link
Member

@HaoZeke HaoZeke commented Jan 28, 2024

Closes #35. Needs documentation. (present partially at https://haozeke.github.io/asv_bench_memray/) The example plugin accompanying this is https://github.com/HaoZeke/asv_bench_memray.

@HaoZeke HaoZeke added this to the 0.1.1 milestone Jan 28, 2024
@HaoZeke HaoZeke changed the title ENH: Support externally defined plugins ENH: Support externally defined benchmark plugins Jan 28, 2024
@HaoZeke HaoZeke requested a review from mattip January 28, 2024 21:55
@mattip
Copy link
Contributor

mattip commented Jan 29, 2024

Could you add a link to the example somewhere in the ASV documentation, or open another issue to specifically document this feature? Other than that LGTM.

@HaoZeke
Copy link
Member Author

HaoZeke commented Feb 1, 2024

Could you add a link to the example somewhere in the ASV documentation, or open another issue to specifically document this feature? Other than that LGTM.

Makes sense, @mattip. I added a list of external plugins and some development documentation.

@mattip mattip merged commit 5dac31b into airspeed-velocity:main Feb 2, 2024
4 checks passed
@mattip
Copy link
Contributor

mattip commented Feb 2, 2024

Thanks @HaoZeke

@HaoZeke HaoZeke deleted the externalPlugins branch February 2, 2024 12:01
@HaoZeke HaoZeke modified the milestones: 0.1.1, 0.2.0 Feb 11, 2024
@HaoZeke HaoZeke mentioned this pull request Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENH: Support external plugins
2 participants