Add PMD to prevent system printout (#12)

* Add PMD to prevent system printout

* Add pr template

* Update pr template

.github/pull_request_template.md

@@ -0,0 +1,8 @@
+**⚠️ Please create this PR against `airbytehq/json-avro-converter` as the base repository, instead of the default `allegro/json-avro-converter`.⚠️**
+
+## Summary
+
+## Checklist
+- [ ] Write unit tests
+- [ ] Make sure there is no logging in the Json / Avro conversion code
+- [ ] Update documentation in `README.md`

converter/build.gradle

@@ -17,6 +17,7 @@ plugins {
     // id 'jacoco'
     // https://github.com/melix/jmh-gradle-plugin#what-plugin-version-to-use
     id 'me.champeau.gradle.jmh' version '0.5.3'
+    id 'pmd'
 }
 
 apply plugin: 'com.commercehub.gradle.plugin.avro'
@@ -74,3 +75,9 @@ test {
         exceptionFormat 'full'
     }
 }
+
+pmd {
+    toolVersion = "6.41.0"
+    ruleSetFiles = files("config/pmd.xml")
+    ruleSets = []
+}

converter/config/pmd.xml

@@ -0,0 +1,14 @@
+<?xml version="1.0"?>
+
+<ruleset name="Custom Rules"
+  xmlns="http://pmd.sourceforge.net/ruleset/2.0.0"
+  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+  xsi:schemaLocation="http://pmd.sourceforge.net/ruleset/2.0.0 https://pmd.sourceforge.io/ruleset_2_0_0.xsd">
+
+  <description>
+    PMD configuration
+  </description>
+
+  <rule ref="category/java/bestpractices.xml/SystemPrintln" />
+
+</ruleset>