[source-mysql] 7084 source mysql regression in 39x date parsing errors #49932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for fractions of a second an an offset
…for fractions of a second an an offset
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…for fractions of a second an an offset
octavia-squidington-iii
added
area/connectors
…for fractions of a second an an offset
octavia-squidington-iii
added
the
area/documentation
rodireich
commented
Dec 19, 2024
| .optionalEnd() | ||
| .appendOffset("+HH:mm", "Z") | ||
| .optionalEnd() | ||
| .toFormatter() |
There was a problem hiding this comment.
This is painful 😓
There was a problem hiding this comment.
I found chatgpt useful for generating this kind of code. Even so, it's still annoying.
There was a problem hiding this comment.
It actually gave me wrong advice here, much to my delight
maybe humans still got a chance 🤭
| val offsetDateTime = | ||
| try { | ||
| OffsetDateTime.parse(stateValue, formatter) | ||
| } catch (_: DateTimeParseException) { |
There was a problem hiding this comment.
If value include no +xx:xx or Z then we create an offset datetime with an assumed UTC offset.
This is done via a LocalDate.
theyueli
changed the title
postamar
approved these changes
Dec 19, 2024
| .optionalEnd() | ||
| .appendOffset("+HH:mm", "Z") | ||
| .optionalEnd() | ||
| .toFormatter() |
There was a problem hiding this comment.
I found chatgpt useful for generating this kind of code. Even so, it's still annoying.
| } catch (_: DateTimeParseException) { | ||
| // if no offset exists, we assume it's UTC | ||
| LocalDateTime.parse(stateValue, formatter) | ||
| .atOffset(java.time.ZoneOffset.UTC) |
There was a problem hiding this comment.
why the qualified class name??
| "'2025-09-03T05:23:35Z', '2025-09-03T05:23:35.000000Z'", | ||
| "'2025-09-03T05:23:35 Z', '2025-09-03T05:23:35.000000Z'", | ||
| "'2025-09-03T05:23:35.12345 +12:34', '2025-09-03T05:23:35.123450+12:34'", | ||
| ) |
rodireich
deleted the
7084-source-mysql--regression-in-39x-date-parsing-errors
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
A saved state timestamp with timezone may have a variation due to legacy mysql:
We need to be able to parse all variations in order to be backward compatible with existing states saved by legacy connector.
Once a state was read we should always emit a normalized value when saving back to state.
How
Rather than relying on fallback default
Jsons.valueToTree()we are declaring a datetime formatter that can accommodate all above variations.User Impact
This should fix syncs jobs that are failing to start to to cursor values saved in an unexpected format.
Can this PR be safely reverted and rolled back?