Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement converters for airbyte type/value to SQL #49924

Merged
merged 8 commits into from
Dec 19, 2024
Merged

feat: implement converters for airbyte type/value to SQL #49924

merged 8 commits into from
Dec 19, 2024

Conversation

jdpgrailsdev
Copy link
Contributor

@jdpgrailsdev jdpgrailsdev commented Dec 18, 2024 •
edited
Loading

What

  • First pass at implementing type/value converters for SQL and new bulk CDK

How

  • Create type and value converts to convert from Airbyte to SQL
  • Implemented in destination for now to enable fast iteration. These will eventually move to the CDK.

N.B.: This specifically does not use jOOQ, as is used in the previous CDK and MSSQL destination. Instead, it ops for a simple Java to SQL conversion logic.

Review guide

  1. AirbyteTypeToSqlType.kt
  2. AirbyteValueToSqlValue.kt
  3. SqlModels.kt

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@jdpgrailsdev jdpgrailsdev requested a review from a team as a code owner December 18, 2024 20:51
@vercel Vercel
Copy link

vercel bot commented Dec 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2024 5:58pm

@octavia-squidington-iv octavia-squidington-iv requested a review from a team December 18, 2024 20:52
@jdpgrailsdev jdpgrailsdev requested review from a team and removed request for a team December 18, 2024 21:02
@octavia-squidington-iv octavia-squidington-iv requested a review from a team December 18, 2024 21:03
edgao
edgao reviewed Dec 18, 2024
View reviewed changes
Copy link
Contributor

@edgao edgao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This specifically does not use jOOQ

❤️

...ns/connectors/destination-mssql-v2/src/main/kotlin/io/airbyte/cdk/load/data/sql/SqlModels.kt Outdated Show resolved Hide resolved
...ns/connectors/destination-mssql-v2/src/main/kotlin/io/airbyte/cdk/load/data/sql/SqlModels.kt Outdated Show resolved Hide resolved
...estination-mssql-v2/src/test/kotlin/io/airbyte/cdk/load/data/sql/AirbyteTypeToSqlTypeTest.kt Outdated Show resolved Hide resolved
...rs/destination-mssql-v2/src/main/kotlin/io/airbyte/cdk/load/data/sql/AirbyteTypeToSqlType.kt Outdated Show resolved Hide resolved
...rs/destination-mssql-v2/src/main/kotlin/io/airbyte/cdk/load/data/sql/AirbyteTypeToSqlType.kt Outdated Show resolved Hide resolved
@octavia-squidington-iv octavia-squidington-iv requested a review from a team December 18, 2024 23:06
@jdpgrailsdev jdpgrailsdev merged commit 9cc3650 into move/destination-mssql-v2 Dec 19, 2024
30 of 36 checks passed
@jdpgrailsdev jdpgrailsdev deleted the jonathan/airbyte-type-value-to-sql branch December 19, 2024 18:16
jdpgrailsdev added a commit that referenced this pull request Dec 19, 2024
@jdpgrailsdev
feat: implement converters for airbyte type/value to SQL (#49924)
7b0ad97
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnny-schmidt johnny-schmidt johnny-schmidt left review comments

@edgao edgao edgao approved these changes

@gosusnp gosusnp Awaiting requested review from gosusnp

Assignees
No one assigned
Labels
area/connectors Connector related issues connectors/destination/mssql-v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jdpgrailsdev @edgao @johnny-schmidt @octavia-squidington-iii