Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(python-cdk): bump jsonschema version to ~4.17.3 #48513

Conversation

cbini
Copy link

@cbini cbini commented Nov 15, 2024

What

Update jsonschema dependency to make PyAirbyte compatible with dbt-common. This dependency needs to be updated in the CDK in order to make it available downstream.

Closes:

How

  • Bumped jsonschema constraint to ~4.17.3 on airbyte-cdk/python/pyproject.toml
  • Ran poetry update jsonschema

Review guide

  1. airbyte-cdk/python/pyproject.toml
  2. airbyte-cdk/python/poetry.lock

User Impact

  • Users should be able to install PyAirbyte into projects alongside dbt-common without dependency conflicts

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

Copy link

vercel bot commented Nov 15, 2024

@cbini is attempting to deploy a commit to the Airbyte Growth Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link

CLAassistant commented Nov 15, 2024

CLA assistant check
All committers have signed the CLA.

@cbini
Copy link
Author

cbini commented Nov 15, 2024

jsonschema>=4.18.0 introduces major changes, deprecating RefResolver, which is used in a non-backward-compatible way in airbyte-cdk. A handful of iterations of test_transform (under airbyte-cdk/python/unit_tests/sources/utils/test_transform.py) fail with:
jsonschema.exceptions._RefResolutionError: Unresolvable JSON pointer: 'definitions/str_type'

Resolving the errors would require migrating a bunch of jsonschema code that I'm not familiar with, but v4.17.3 is the latest version that still passes all airbyte-cdk tests and still satisfies the dbt-common requirement of >=4.0.

@cbini
Copy link
Author

cbini commented Nov 15, 2024

FYI jsonschema was last updated here: #5161

Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, @cbini. Although it’s just a one-line change, it could significantly impact all Python connectors. I’ve asked the team to take a look, but I can’t guarantee they’ll be able to review or accept the change immediately. I’ll check with them and keep you updated.

@airbytehq/dev-python fyi

@marcosmarxm marcosmarxm changed the title build: bump jsonschema feat(python-cdk): bump jsonschema version to ~0.4.17 Nov 18, 2024
@marcosmarxm
Copy link
Member

@aaronsteers can you take a look into this contribution?

@aaronsteers aaronsteers changed the title feat(python-cdk): bump jsonschema version to ~0.4.17 feat(python-cdk): bump jsonschema version to ~4.17.3 Nov 19, 2024
@aaronsteers
Copy link
Collaborator

@cbini - Moved to new PR here in our new Python CDK Repo:

If tests pass, I'm inclined to merge, but let's continue the conversation over there.

@cbini
Copy link
Author

cbini commented Nov 19, 2024

Thanks all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CDK Connector Development Kit community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants