-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(python-cdk): bump jsonschema version to ~4.17.3
#48513
feat(python-cdk): bump jsonschema version to ~4.17.3
#48513
Conversation
@cbini is attempting to deploy a commit to the Airbyte Growth Team on Vercel. A member of the Team first needs to authorize it. |
jsonschema>=4.18.0 introduces major changes, deprecating Resolving the errors would require migrating a bunch of |
FYI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution, @cbini. Although it’s just a one-line change, it could significantly impact all Python connectors. I’ve asked the team to take a look, but I can’t guarantee they’ll be able to review or accept the change immediately. I’ll check with them and keep you updated.
@airbytehq/dev-python fyi
~0.4.17
@aaronsteers can you take a look into this contribution? |
~0.4.17
~4.17.3
@cbini - Moved to new PR here in our new Python CDK Repo: If tests pass, I'm inclined to merge, but let's continue the conversation over there. |
Thanks all! |
What
Update
jsonschema
dependency to make PyAirbyte compatible withdbt-common
. This dependency needs to be updated in the CDK in order to make it available downstream.Closes:
jsonschema
library PyAirbyte#398PyAirbyte
withdbt-core
PyAirbyte#441How
jsonschema
constraint to~4.17.3
onairbyte-cdk/python/pyproject.toml
poetry update jsonschema
Review guide
airbyte-cdk/python/pyproject.toml
airbyte-cdk/python/poetry.lock
User Impact
dbt-common
without dependency conflictsCan this PR be safely reverted and rolled back?