Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: update --use-local-cdk arg in airbyte-ci, adds --use-cdk-ref arg #48457

Merged
merged 12 commits into from
Nov 13, 2024

Conversation

aaronsteers
Copy link
Collaborator

@aaronsteers aaronsteers commented Nov 12, 2024

What

This PR updates --use-local-cdk behavior for Python connectors and adds --use-cdk-ref flag.

Testing here:

How

Review guide

User Impact

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@aaronsteers aaronsteers requested a review from a team as a code owner November 12, 2024 05:50
Copy link

vercel bot commented Nov 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2024 0:09am

@aaronsteers
Copy link
Collaborator Author

@alafanechere - This is only a start.
Do you have time to assist?

If poetry add doesn't work, we could revert to the pip inject method, but just with an alternate path.

Copy link
Contributor

@alafanechere alafanechere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes as your directory mounting logic will not work as it is. Feel free to force merge once you fixed it.
And please bump the pipelines package version + add an entry to the changelog in README.md

@octavia-squidington-iii octavia-squidington-iii added the CDK Connector Development Kit label Nov 12, 2024
@octavia-squidington-iii octavia-squidington-iii removed the CDK Connector Development Kit label Nov 12, 2024
@aaronsteers aaronsteers changed the title Draft: update airbyte-ci local cdk code CI: update --use-local-cdk arg in airbyte-ci, adds --use-cdk-ref arg Nov 13, 2024
@aaronsteers
Copy link
Collaborator Author

@alafanechere - Tests are looking good so I'm yolo-merging this to try to resolve a couple other issues. Will gather data as we run in a variety of environments, and will try to resolve what comes up.

@aaronsteers aaronsteers merged commit 0efc0f5 into master Nov 13, 2024
32 of 34 checks passed
@aaronsteers aaronsteers deleted the aj/airbyte-ci/update-python-local-cdk-code branch November 13, 2024 02:40
@aaronsteers aaronsteers restored the aj/airbyte-ci/update-python-local-cdk-code branch November 13, 2024 02:41
@aaronsteers
Copy link
Collaborator Author

Intentionally un-deleting branch (for now) because we have a CDK pipeline pinned to it.

Copy link

sentry-io bot commented Nov 13, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ FileExistsError: Local CDK not found at '/home/runner/work/airbyte/airbyte-python-cdk' pipelines.dagger.actions.python.common in apply... View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants