-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: update --use-local-cdk
arg in airbyte-ci
, adds --use-cdk-ref
arg
#48457
CI: update --use-local-cdk
arg in airbyte-ci
, adds --use-cdk-ref
arg
#48457
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@alafanechere - This is only a start. If |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting changes as your directory mounting logic will not work as it is. Feel free to force merge once you fixed it.
And please bump the pipelines
package version + add an entry to the changelog in README.md
airbyte-ci/connectors/pipelines/pipelines/dagger/actions/python/common.py
Outdated
Show resolved
Hide resolved
airbyte-ci/connectors/pipelines/pipelines/dagger/actions/python/common.py
Outdated
Show resolved
Hide resolved
airbyte-ci/connectors/pipelines/pipelines/dagger/actions/python/common.py
Outdated
Show resolved
Hide resolved
airbyte-ci/connectors/pipelines/pipelines/dagger/actions/python/common.py
Outdated
Show resolved
Hide resolved
airbyte-ci/connectors/pipelines/pipelines/dagger/actions/python/common.py
Outdated
Show resolved
Hide resolved
--use-local-cdk
arg in airbyte-ci
, adds --use-cdk-ref
arg
@alafanechere - Tests are looking good so I'm yolo-merging this to try to resolve a couple other issues. Will gather data as we run in a variety of environments, and will try to resolve what comes up. |
Intentionally un-deleting branch (for now) because we have a CDK pipeline pinned to it. |
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
What
This PR updates
--use-local-cdk
behavior for Python connectors and adds--use-cdk-ref
flag.Testing here:
--use-local-cdk
method for testing connectors airbyte-python-cdk#40How
Review guide
User Impact
Can this PR be safely reverted and rolled back?