-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore[Python-CDK]: Bump Pendulum #47266
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
@aaronsteers I made a small Python script import sys
import pendulum
print("Python version:", sys.version)
print("pendulum version:", pendulum.__version__)
date = pendulum.datetime(2001, 5, 21, 12)
print(date.to_rfc3339_string())
print(f"{date}") I got results:
Maybe problem is with implicit casting to string, because |
@szemek - The challenge here is that the default/defacto behavior will exist in many places (in the CDK and also in the connectors) to simply use the default string rendering: For now, at least, I think we have to close this PR and rethink/regroup on this. Adding to the complexity here is that Pendulum 3.0 appears to be abandoned since January of this year. I can't make a strong case to move the CDK and all connectors over to 3.0 in this case - because of lack of support and also the breaking change in how datetimes are rendered by default. Other options I am considering:
None of this is trivial because it all requires refactoring and retesting. |
Continuation of:
jsonschema
andpendulum
dependencies #45677What
Pendulum doesn't have wheels for <3.0. Bumping the Pendulum version should allow images to build correctly and more reliably on different platforms.
Breaking changes in Pendulum 3.0 described here:
Most connectors are unaffected. A few will need small changes, in their tests or in the connector code. We expect tests will uncover these issues, and mitigations should be straightforward.
Additionally, we can bump a few other dependencies while we are at it.
How
Review guide
User Impact
Can this PR be safely reverted and rolled back?