source-mysql: normalize class names

airbytehq · Dec 19, 2024 · 77da7e7 · 77da7e7
1 parent ebbbb9d
commit 77da7e7
Show file tree

Hide file tree

Showing 27 changed files with 418 additions and 461 deletions.
diff --git a/airbyte-integrations/connectors/source-mysql/build.gradle b/airbyte-integrations/connectors/source-mysql/build.gradle
@@ -3,7 +3,7 @@ plugins {
 }
 
 application {
-    mainClass = 'io.airbyte.integrations.source.mysql.MysqlSource'
+    mainClass = 'io.airbyte.integrations.source.mysql.MySqlSource'
 }
 
 airbyteBulkConnector {
@@ -14,10 +14,8 @@ airbyteBulkConnector {
 
 dependencies {
     implementation 'com.mysql:mysql-connector-j:9.1.0'
-    implementation 'org.codehaus.plexus:plexus-utils:4.0.0'
     implementation 'io.debezium:debezium-connector-mysql'
 
-    testImplementation platform('org.testcontainers:testcontainers-bom:1.20.2')
     testImplementation 'org.testcontainers:mysql'
     testImplementation("io.mockk:mockk:1.12.0")
 }
diff --git a/.../integrations/source/mysql/MysqlSource.kt → .../integrations/source/mysql/MySqlSource.kt b/.../integrations/source/mysql/MysqlSource.kt → .../integrations/source/mysql/MySqlSource.kt
@@ -3,7 +3,7 @@ package io.airbyte.integrations.source.mysql
 
 import io.airbyte.cdk.AirbyteSourceRunner
 
-object MysqlSource {
+object MySqlSource {
     @JvmStatic
     fun main(args: Array<String>) {
         AirbyteSourceRunner.run(*args)

diff --git a/.../cdc/converters/MySqlTemporalConverter.kt → ...e/mysql/MySqlSourceCdcCustomConverters.kt b/.../cdc/converters/MySqlTemporalConverter.kt → ...e/mysql/MySqlSourceCdcCustomConverters.kt
@@ -2,7 +2,7 @@
  * Copyright (c) 2024 Airbyte, Inc., all rights reserved.
  */
 
-package io.airbyte.integrations.source.mysql.cdc.converters
+package io.airbyte.integrations.source.mysql
 
 import io.airbyte.cdk.data.LocalDateCodec
 import io.airbyte.cdk.data.LocalDateTimeCodec
@@ -20,7 +20,52 @@ import java.time.LocalTime
 import java.time.ZonedDateTime
 import org.apache.kafka.connect.data.SchemaBuilder
 
-class MySqlTemporalConverter : RelationalColumnCustomConverter {
+class MySqlSourceCdcBooleanConverter : RelationalColumnCustomConverter {
+
+    override val debeziumPropertiesKey: String = "boolean"
+    override val handlers: List<RelationalColumnCustomConverter.Handler> =
+        listOf(booleanHandler, tinyint1Handler)
+
+    companion object {
+        val booleanHandler =
+            RelationalColumnCustomConverter.Handler(
+                predicate = { it.typeName().startsWith("BOOL", ignoreCase = true) },
+                outputSchema = SchemaBuilder.bool(),
+                partialConverters =
+                    listOf(
+                        PartialConverter {
+                            when (it) {
+                                null -> Converted(false)
+                                is Boolean -> Converted(it)
+                                else -> NoConversion
+                            }
+                        }
+                    )
+            )
+
+        val tinyint1Handler =
+            RelationalColumnCustomConverter.Handler(
+                predicate = {
+                    it.typeName().equals("TINYINT", ignoreCase = true) &&
+                        it.length().isPresent &&
+                        it.length().asInt == 1
+                },
+                outputSchema = SchemaBuilder.bool(),
+                partialConverters =
+                    listOf(
+                        PartialConverter {
+                            when (it) {
+                                null -> Converted(false)
+                                is Number -> Converted(it != 0)
+                                else -> NoConversion
+                            }
+                        }
+                    )
+            )
+    }
+}
+
+class MySqlSourceCdcTemporalConverter : RelationalColumnCustomConverter {
 
     override val debeziumPropertiesKey: String = "temporal"
 

diff --git a/...ations/source/mysql/MysqlCdcMetaFields.kt → .../source/mysql/MySqlSourceCdcMetaFields.kt b/...ations/source/mysql/MysqlCdcMetaFields.kt → .../source/mysql/MySqlSourceCdcMetaFields.kt
@@ -9,7 +9,7 @@ import io.airbyte.cdk.discover.CdcStringMetaFieldType
 import io.airbyte.cdk.discover.FieldType
 import io.airbyte.cdk.discover.MetaField
 
-enum class MysqlCdcMetaFields(
+enum class MySqlSourceCdcMetaFields(
     override val type: FieldType,
 ) : MetaField {
     CDC_CURSOR(CdcIntegerMetaFieldType),

diff --git a/...rations/source/mysql/cdc/MySqlPosition.kt → ...ns/source/mysql/MySqlSourceCdcPosition.kt b/...rations/source/mysql/cdc/MySqlPosition.kt → ...ns/source/mysql/MySqlSourceCdcPosition.kt
@@ -2,13 +2,14 @@
  * Copyright (c) 2024 Airbyte, Inc., all rights reserved.
  */
 
-package io.airbyte.integrations.source.mysql.cdc
+package io.airbyte.integrations.source.mysql
 
 import kotlin.io.path.Path
 import kotlin.io.path.extension
 
 /** WAL position datum for MySQL. */
-data class MySqlPosition(val fileName: String, val position: Long) : Comparable<MySqlPosition> {
+data class MySqlSourceCdcPosition(val fileName: String, val position: Long) :
+    Comparable<MySqlSourceCdcPosition> {
 
     /**
      * Numerical value encoded in the extension of the binlog file name.
@@ -31,5 +32,6 @@ data class MySqlPosition(val fileName: String, val position: Long) : Comparable<
     val cursorValue: Long
         get() = (fileExtension.toLong() shl Int.SIZE_BITS) or position
 
-    override fun compareTo(other: MySqlPosition): Int = cursorValue.compareTo(other.cursorValue)
+    override fun compareTo(other: MySqlSourceCdcPosition): Int =
+        cursorValue.compareTo(other.cursorValue)
 }
diff --git a/.../source/mysql/MysqlSourceConfiguration.kt → .../source/mysql/MySqlSourceConfiguration.kt b/.../source/mysql/MysqlSourceConfiguration.kt → .../source/mysql/MySqlSourceConfiguration.kt
@@ -22,7 +22,7 @@ import java.time.Duration
 private val log = KotlinLogging.logger {}
 
 /** Mysql-specific implementation of [SourceConfiguration] */
-data class MysqlSourceConfiguration(
+data class MySqlSourceConfiguration(
     override val realHost: String,
     override val realPort: Int,
     override val sshTunnel: SshTunnelMethodConfiguration?,
@@ -41,16 +41,16 @@ data class MysqlSourceConfiguration(
 ) : JdbcSourceConfiguration, CdcSourceConfiguration {
     override val global = incrementalConfiguration is CdcIncrementalConfiguration
 
-    /** Required to inject [MysqlSourceConfiguration] directly. */
+    /** Required to inject [MySqlSourceConfiguration] directly. */
     @Factory
     private class MicronautFactory {
         @Singleton
         fun mysqlSourceConfig(
             factory:
                 SourceConfigurationFactory<
-                    MysqlSourceConfigurationSpecification, MysqlSourceConfiguration>,
-            supplier: ConfigurationSpecificationSupplier<MysqlSourceConfigurationSpecification>,
-        ): MysqlSourceConfiguration = factory.make(supplier.get())
+                    MySqlSourceConfigurationSpecification, MySqlSourceConfiguration>,
+            supplier: ConfigurationSpecificationSupplier<MySqlSourceConfigurationSpecification>,
+        ): MySqlSourceConfiguration = factory.make(supplier.get())
     }
 }
 
@@ -71,14 +71,14 @@ enum class InvalidCdcCursorPositionBehavior {
 }
 
 @Singleton
-class MysqlSourceConfigurationFactory @Inject constructor(val featureFlags: Set<FeatureFlag>) :
-    SourceConfigurationFactory<MysqlSourceConfigurationSpecification, MysqlSourceConfiguration> {
+class MySqlSourceConfigurationFactory @Inject constructor(val featureFlags: Set<FeatureFlag>) :
+    SourceConfigurationFactory<MySqlSourceConfigurationSpecification, MySqlSourceConfiguration> {
 
     constructor() : this(emptySet())
 
     override fun makeWithoutExceptionHandling(
-        pojo: MysqlSourceConfigurationSpecification,
-    ): MysqlSourceConfiguration {
+        pojo: MySqlSourceConfigurationSpecification,
+    ): MySqlSourceConfiguration {
         val realHost: String = pojo.host
         val realPort: Int = pojo.port
         val sshTunnel: SshTunnelMethodConfiguration? = pojo.getTunnelMethodValue()
@@ -115,20 +115,21 @@ class MysqlSourceConfigurationFactory @Inject constructor(val featureFlags: Set<
                                 "SSL encryption or an SSH tunnel."
                         )
                     }
-                    MysqlJdbcEncryption(sslMode = SSLMode.PREFERRED)
+                    MySqlSourceEncryption(sslMode = MySqlSourceEncryption.SslMode.PREFERRED)
                 }
-                is EncryptionRequired -> MysqlJdbcEncryption(sslMode = SSLMode.REQUIRED)
+                is EncryptionRequired ->
+                    MySqlSourceEncryption(sslMode = MySqlSourceEncryption.SslMode.REQUIRED)
                 is SslVerifyCertificate ->
-                    MysqlJdbcEncryption(
-                        sslMode = SSLMode.VERIFY_CA,
+                    MySqlSourceEncryption(
+                        sslMode = MySqlSourceEncryption.SslMode.VERIFY_CA,
                         caCertificate = encryption.sslCertificate,
                         clientCertificate = encryption.sslClientCertificate,
                         clientKey = encryption.sslClientKey,
                         clientKeyPassword = encryption.sslClientPassword
                     )
                 is SslVerifyIdentity ->
-                    MysqlJdbcEncryption(
-                        sslMode = SSLMode.VERIFY_IDENTITY,
+                    MySqlSourceEncryption(
+                        sslMode = MySqlSourceEncryption.SslMode.VERIFY_IDENTITY,
                         caCertificate = encryption.sslCertificate,
                         clientCertificate = encryption.sslClientCertificate,
                         clientKey = encryption.sslClientKey,
@@ -178,7 +179,7 @@ class MysqlSourceConfigurationFactory @Inject constructor(val featureFlags: Set<
                             },
                     )
             }
-        return MysqlSourceConfiguration(
+        return MySqlSourceConfiguration(
             realHost = realHost,
             realPort = realPort,
             sshTunnel = sshTunnel,

diff --git a/.../MysqlSourceConfigurationSpecification.kt → .../MySqlSourceConfigurationSpecification.kt b/.../MysqlSourceConfigurationSpecification.kt → .../MySqlSourceConfigurationSpecification.kt
@@ -29,7 +29,7 @@ import jakarta.inject.Singleton
 /**
  * The object which is mapped to the Mysql source configuration JSON.
  *
- * Use [MysqlSourceConfiguration] instead wherever possible. This object also allows injecting
+ * Use [MySqlSourceConfiguration] instead wherever possible. This object also allows injecting
  * values through Micronaut properties, this is made possible by the classes named
  * `MicronautPropertiesFriendly.*`.
  */
@@ -40,7 +40,7 @@ import jakarta.inject.Singleton
 @Singleton
 @ConfigurationProperties(CONNECTOR_CONFIG_PREFIX)
 @SuppressFBWarnings(value = ["NP_NONNULL_RETURN_VIOLATION"], justification = "Micronaut DI")
-class MysqlSourceConfigurationSpecification : ConfigurationSpecification() {
+class MySqlSourceConfigurationSpecification : ConfigurationSpecification() {
     @JsonProperty("host")
     @JsonSchemaTitle("Host")
     @JsonSchemaInject(json = """{"order":1}""")