-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: replace faker with hardcoded source #42
Conversation
Caution Review failedThe pull request is closed. 📝 Walkthrough📝 WalkthroughWalkthroughThe pull request modifies the GitHub Actions workflow for testing connectors. It updates the connector being tested from Changes
Possibly related PRs
Suggested labels
Warning Rate limit exceeded@aaronsteers has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 0 minutes and 26 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
.github/workflows/connector-tests.yml (1)
Line range hint
4-10
: Track TODOs and temporary configurationsHey there! 👋 I noticed a few TODOs and temporary configurations that we might want to track:
- There's a TODO about running these tests after "PyTest (Fast)"
- We're using a temporary branch (
aj/airbyte-ci/update-python-local-cdk-code
) that needs to be reverted tomaster
Would you like me to create GitHub issues to track these items? This way we won't forget to address them after the Airbyte CI is released. 😊
Also applies to: 93-95
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
.github/workflows/connector-tests.yml
(1 hunks)
🔇 Additional comments (2)
.github/workflows/connector-tests.yml (2)
Line range hint 44-45
: Question about runner configuration
I noticed we're using ubuntu-latest
instead of the commented out connector-test-large
. Is this intentional? Just want to make sure we're using the optimal runner for these tests. 🤔
wdyt about uncommenting the connector-test-large
runner if that's still the preferred option?
71-71
: Verify test coverage with hardcoded records
The switch from source-faker
to source-hardcoded-records
looks good! Just wondering if we should verify a few things:
- Does the hardcoded source provide equivalent test coverage compared to faker?
- Are there any other workflows expecting faker data that need updating?
wdyt? 🤔
Summary by CodeRabbit
source-faker
tosource-hardcoded-records
.