Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: replace faker with hardcoded source #42

Merged
merged 4 commits into from
Nov 13, 2024

Conversation

aaronsteers
Copy link
Contributor

@aaronsteers aaronsteers commented Nov 13, 2024

Summary by CodeRabbit

  • Chores
    • Updated the connector being tested in CI from source-faker to source-hardcoded-records.
    • Refined conditions for executing CI jobs based on detected changes in the Airbyte project.
    • Simplified output reporting by focusing on the first failed step in CI job results.
    • Maintained concurrency settings and job permissions for efficient CI processes.

@aaronsteers aaronsteers changed the title replace faker with hardcoded source ci: replace faker with hardcoded source Nov 13, 2024
@aaronsteers aaronsteers marked this pull request as ready for review November 13, 2024 04:57
Copy link
Contributor

coderabbitai bot commented Nov 13, 2024

Caution

Review failed

The pull request is closed.

📝 Walkthrough
📝 Walkthrough

Walkthrough

The pull request modifies the GitHub Actions workflow for testing connectors. It updates the connector being tested from source-faker to source-hardcoded-records in the connectors_ci job. The cdk_changes job is structured to assess changes in specific directories and files, allowing the connectors_ci job to be conditionally skipped if no relevant changes are found. The timeout for the connectors_ci job is set to 360 minutes, and the overall concurrency settings and job permissions are retained.

Changes

File Path Change Summary
.github/workflows/connector-tests.yml Updated connector in connectors_ci job from source-faker to source-hardcoded-records; refined job conditions and maintained concurrency settings.

Possibly related PRs

  • CI: update test workflows #26: The changes in the main PR regarding the connectors_ci job's strategy matrix and conditions for execution are related to the overall goal of combining test workflows, as both PRs focus on refining CI processes for testing connectors.

Suggested labels

ci

Warning

Rate limit exceeded

@aaronsteers has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 0 minutes and 26 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 3a9d35c and 90d2973.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)
.github/workflows/connector-tests.yml (1)

Line range hint 4-10: Track TODOs and temporary configurations

Hey there! 👋 I noticed a few TODOs and temporary configurations that we might want to track:

  1. There's a TODO about running these tests after "PyTest (Fast)"
  2. We're using a temporary branch (aj/airbyte-ci/update-python-local-cdk-code) that needs to be reverted to master

Would you like me to create GitHub issues to track these items? This way we won't forget to address them after the Airbyte CI is released. 😊

Also applies to: 93-95

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 6e71dc0 and d057b24.

📒 Files selected for processing (1)
  • .github/workflows/connector-tests.yml (1 hunks)
🔇 Additional comments (2)
.github/workflows/connector-tests.yml (2)

Line range hint 44-45: Question about runner configuration

I noticed we're using ubuntu-latest instead of the commented out connector-test-large. Is this intentional? Just want to make sure we're using the optimal runner for these tests. 🤔

wdyt about uncommenting the connector-test-large runner if that's still the preferred option?


71-71: Verify test coverage with hardcoded records

The switch from source-faker to source-hardcoded-records looks good! Just wondering if we should verify a few things:

  1. Does the hardcoded source provide equivalent test coverage compared to faker?
  2. Are there any other workflows expecting faker data that need updating?

wdyt? 🤔

@github-actions github-actions bot added the ci label Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant