-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore(linting): Add ruff lint rules #22
Open
aaronsteers
wants to merge
5
commits into
main
Choose a base branch
from
aj/chore/add-ruff-lint-rules-2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
bd39e9b
drive-by fix: delete duplicate project file
aaronsteers 2a2f543
chore(linting): import rules from other PR
aaronsteers 6460550
Merge branch 'main' into aj/chore/add-ruff-lint-rules-2
aaronsteers 5d3dc2e
Merge branch 'main' into aj/chore/add-ruff-lint-rules-2
aaronsteers 90d1d8b
Merge branch 'main' into aj/chore/add-ruff-lint-rules-2
natikgadzhi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codebase verification
Preview mode is already disabled in the codebase
Hey! I noticed that while this PR is adding
preview = true
, there's actually a conflicting setting elsewhere in the codebase that setspreview = false
. Since preview features can indeed introduce breaking changes, would it be better to keep it disabled for now? This would help maintain stability across ruff updates. wdyt?🔗 Analysis chain
Consider the implications of enabling preview mode
Hey! I noticed you've enabled preview mode for ruff. While this gives us access to the latest features, it might introduce breaking changes in future updates. What do you think about adding a comment explaining why we need preview mode? This would help future maintainers understand the decision. wdyt?
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
Length of output: 75
Script:
Length of output: 586