-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: make it easier to find the connector test report url upon failure #153
Conversation
📝 WalkthroughWalkthroughThe pull request introduces modifications to the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
What do you think about the suggested reviewers? Do they seem like a good fit for this PR? Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
.github/workflows/connector-tests.yml (2)
166-168
: Consider adding the report URL to the error message, wdyt?The error message is now more concise, which is great! 🎯 To make it even more helpful, we could include the report URL directly in the error message. This would make it immediately visible in the GitHub UI when the error occurs.
- echo "::error::Test failed for connector '${{ matrix.connector }}' on step '${failed_step}'. " + echo "::error::Test failed for connector '${{ matrix.connector }}' on step '${failed_step}'. See report: ${html_report_url}"
169-169
: How about adding the report URL to the step summary for better visibility?The report URL is now included in the logs, but it might be more visible if we also add it to the step summary. GitHub displays step summaries prominently in the UI, making them easier to find. 🔍
echo "See the execution report for details: ${html_report_url}" + echo "## Test Report" >> $GITHUB_STEP_SUMMARY + echo "📊 [View detailed test report](${html_report_url})" >> $GITHUB_STEP_SUMMARY
Summary by CodeRabbit
New Features
Bug Fixes