Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bring poetry.lock back in sync with pyproject.toml #126

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

arr-ee
Copy link
Contributor

@arr-ee arr-ee commented Dec 5, 2024

(Partially) fixes #125 by re-syncing poetry.lock with pyproject.toml

@arr-ee arr-ee changed the title Bring poetry.lock back in sync with pyproject.toml chore(deps): bring poetry.lock back in sync with pyproject.toml Dec 5, 2024
@natikgadzhi natikgadzhi changed the title chore(deps): bring poetry.lock back in sync with pyproject.toml fix: bring poetry.lock back in sync with pyproject.toml Dec 5, 2024
@natikgadzhi natikgadzhi enabled auto-merge (squash) December 5, 2024 01:54
@arr-ee
Copy link
Contributor Author

arr-ee commented Dec 5, 2024

Re: shopify tests: not sure if this is normal but this is what I see in the logs:

------------------------------ Captured log setup ------------------------------
WARNING  root:conftest.py:137 Connector config file not found at /test_input/secrets/config.json

All acceptance tests fail with ValueError: No catalog message was emitted or similar errors indicating lack of data — not sure why it's not 401 or something.

See also: https://github.com/airbytehq/airbyte-python-cdk/actions/runs/12171669042/job/33948995326?pr=126#step:5:53

Connectors CI tests on source-shopify: Secret SECRET_SOURCE-SHOPIFY-TRANSACTIONS-WITH-USER-ID__CREDS can't be retrieved as airbyte-connector-testing-secret-store is not available — this is unlikely to be caused by the PR so I will leave the investigation at that.

@aaronsteers
Copy link
Contributor

@arr-ee - re:

Connectors CI tests on source-shopify: Secret SECRET_SOURCE-SHOPIFY-TRANSACTIONS-WITH-USER-ID__CREDS can't be retrieved as airbyte-connector-testing-secret-store is not available...

This is due to running from a fork, and not having access to integration test secrets. In other words, it is to be expected, and not something we need to block on.

Copy link
Contributor

@aaronsteers aaronsteers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved - merging! 🚢

Thanks very much for the contribution!

@aaronsteers aaronsteers disabled auto-merge December 5, 2024 22:26
@aaronsteers aaronsteers merged commit 27372f8 into airbytehq:main Dec 5, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

poetry.lock is out of sync with pyproject.toml
3 participants