ci: dont create builder pr if sdm publish fails

[aaronsteers]

Summary by CodeRabbit

• New Features
  • Enhanced control flow for job dependencies in the publishing workflow.
  • Added a check for existing Docker tags to prevent overwriting during publishing.
• Bug Fixes
  • Improved error handling for Docker publishing steps, providing clearer feedback on issues.
• Refactor
  • Clarified logic for building and pushing Docker images with distinct steps for versioned and SHA tags.

[lmossman]

LGTM

[coderabbitai]

Caution

Review failed

The pull request is closed.

📝 Walkthrough

📝 Walkthrough

Walkthrough

The pull request modifies the .github/workflows/pypi_publish.yml workflow file to improve the functionality of the publishing process. Key changes include establishing a dependency between the update-connector-builder job and the publish_sdm job, refining conditions for job execution, and adding steps to check for existing Docker tags before publishing. The overall control flow has been adjusted for better sequencing, and error handling has been enhanced to provide clearer feedback during the Docker publishing steps.

Changes

File	Change Summary
.github/workflows/pypi_publish.yml	- Added job dependency: publish_sdm is now required for update-connector-builder. - Updated conditions for update-connector-builder to check for successful builds and event types. - Added a step in publish_sdm to check for existing Docker tags before publishing. - Clarified logic for building and pushing Docker images, including handling of versioned and SHA tags.

Possibly related PRs

• Feat: Incorporate SDM in CDK and add publish workflow #58: Introduces a publish workflow for the Source Declarative Manifest (SDM), directly related to the publish_sdm job changes.
• ci: add environment declaration for DockerhHub publish #78: Adds the publish_sdm job to the workflow, aligning with enhancements in the main PR regarding Docker image publishing.
• CI: move SDM image publish to dedicated step #83: Discusses moving the SDM image publish to a dedicated step, relevant to the changes in the publish_sdm job.
• ci: create unified cdk, sdm, and builder publish flow #107: Consolidates publishing processes for the Python package and SDM image, relevant to the modifications enhancing the publish_sdm job.
• ci: auto-publish sdm for each release #122: Updates the publish_sdm job's conditions, directly relating to improvements in Docker image publishing.

Suggested labels

bug

Suggested reviewers

• ChristoGrab
• aaronsteers

What do you think about these suggestions? Would you like to add or modify anything?

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 3c146c7 and 2b59ba8.

📒 Files selected for processing (1)

• .github/workflows/pypi_publish.yml (1 hunks)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.