-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add reasons to AirbyteStreamStatusTraceMessage #74
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ship it!
properties: | ||
quota_reset: | ||
description: "Optional time in ms representing when the API quota is going to be reset" | ||
type: number |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason this isn't just a big int? do we need decimals?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cgardens I am just following the convention. We are using number for timestamp attributes. For instance take a look at the emitted_at in AirbyteTraceMessage
, its defined as a number
emitted_at:
description: "the time in ms that the message was emitted"
type: number
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cgardens @subodh1810 This looks like a bug in the AirbyteTraceMessage
. It was not obvious to me that integer
was not an integer data type and is actually a big integer or that number
is a floating point/double. Should we attempt to fix the AirbyteTraceMessage
either as part of this PR or in a separate PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- let's do it correctly here and use integer.
- let's create an issue to fix airbyte trace meesage and add a todo in the code that that should have been number. don't think this is a good moment to try to fix this old mistake. just want to do it right going forward.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cgardens @jdpgrailsdev added the TODOs in the protocol yaml and created a github issue
https://github.com/airbytehq/airbyte/issues/38163
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tech spec
Protocol review doc
Sample JSON