feat: Introduce is_resumable. #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evantahler
reviewed
Apr 17, 2024
evantahler
reviewed
May 13, 2024
| @@ -429,7 +429,10 @@ definitions: | |||
| items: | |||
| "$ref": "#/definitions/SyncMode" | |||
| source_defined_cursor: | |||
| description: If the source defines the cursor field, then any other cursor field inputs will be ignored. If it does not, either the user_provided one is used, or the default one is used as a backup. | |||
| description: |- | |||
There was a problem hiding this comment.
I thought the yaml line break was just a | not a |-?
There was a problem hiding this comment.
- strips newlines from the end.
I started by pattern matching existing descriptions. I do agree stripping trailing newlines is good.
There was a problem hiding this comment.
Lmk if you disagree!
evantahler
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corresponding protocol PR for https://docs.google.com/document/d/1G0B_R6D_v4avFXXtQuXLK6T6STIVIsBChcWmbuMMTn0/edit.