Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: (DeclarativeOAuthFlow) - add access_token_params property to match the actual spec properties #103

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

bazarnov
Copy link
Contributor

@bazarnov bazarnov commented Nov 27, 2024

What

While working on the migration for TikTok Marketing OAuthFlow, there was a need to encode the access_token_url query parameters to json string instead of url_encoded parameters.

The access_token_params is there to provide such a functionality, in order to match the actual spec provided with the designed protocol DeclarativeOAuth spec this property should exist at the protocol level.

How

  • add the access_token_params object property to the OAuthConfigSpecification.oauth_connector_input_specification.properties
  • made the additionalProperties set to true to allow future lazy spec improvements, even though the protocol could be behind of the actual source / destination spec, allowing us to provide more properties to work with.

@bazarnov bazarnov merged commit b47f0ca into main Nov 27, 2024
6 checks passed
@bazarnov bazarnov deleted the baz/add-access-token-params-to-oauth-spec branch November 27, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants