PR comments

airbytehq · Apr 1, 2024 · 912eec5 · 912eec5
1 parent c762ef3
commit 912eec5
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 6 deletions.
diff --git a/protocol-models/src/main/resources/airbyte_protocol/airbyte_protocol.yaml b/protocol-models/src/main/resources/airbyte_protocol/airbyte_protocol.yaml
@@ -463,8 +463,6 @@ definitions:
       - stream
       - sync_mode
       - destination_sync_mode
-      - generation_id
-      - sync_id
     properties:
       stream:
         "$ref": "#/definitions/AirbyteStream"
@@ -487,13 +485,26 @@ definitions:
           items:
             type: string
       generation_id:
-        description: Monotically increasing numeric id representing the current generation of a stream. This id can be shared across syncs
+        description: 
+        "Monotically increasing numeric id representing the current generation of a stream. This id can be shared across syncs.
+
+        If this is null, it means that the platform is not supporting the refresh and it is expected that no extra id will be added to the records and no data from previous generation will be cleanup.
+        "
         type: integer
       minimum_generation_id:
-        description: The minimum generation id which is needed in a stream. If it is present, the destination will try to delete the data that are part of a generation lower than this property. If it is absent, the destination won't try to delete data
+        description: 
+        "The minimum generation id which is needed in a stream. If it is present, the destination will try to delete the data that are part of a generation lower than this property.
+        If the minimum generation is equals to 0, no data deletion is expected from the destiantion
+        
+        If this is null, it means that the platform is not supporting the refresh and it is expected that no extra id will be added to the records and no data from previous generation will be cleanup.
+        "
         type: integer
       sync_id:
-        description: Monotically increasing numeric id representing the current sync id. This is aimed to be unique per sync.
+        description: 
+        "Monotically increasing numeric id representing the current sync id. This is aimed to be unique per sync.
+        
+        If this is null, it means that the platform is not supporting the refresh and it is expected that no extra id will be added to the records and no data from previous generation will be cleanup.
+        "
         type: integer
   SyncMode:
     type: string

diff --git a/protocol-models/src/main/resources/airbyte_protocol/v0/airbyte_protocol.yaml b/protocol-models/src/main/resources/airbyte_protocol/v0/airbyte_protocol.yaml
@@ -464,7 +464,7 @@ definitions:
       - stream
       - sync_mode
       - destination_sync_mode
-      - current_generation_id
+      - generation_id
       - sync_id
     properties:
       stream: