Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix round seconds formatting in JobResponseMapper #375

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

codewithbear
Copy link

What

Currently if a job has been started (or updated) at the start of minute (seconds = 0) the formatting omits seconds so in the public api it would look like this

"2024-12-03T11:40Z" // actual,
"2024-12-03T11:40:00Z" // expected

How

Using DateTimeFormatter to make sure to always include seconds

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@CLAassistant
Copy link

CLAassistant commented Dec 3, 2024

CLA assistant check
All committers have signed the CLA.

@codewithbear codewithbear force-pushed the fix-list-jobs-public-api-date branch 2 times, most recently from 49a9b68 to c7d82f7 Compare December 3, 2024 12:07
@codewithbear codewithbear force-pushed the fix-list-jobs-public-api-date branch from c7d82f7 to 6e0f520 Compare December 3, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants