feat(temporal): allow customization of SSL mode for external db

[CyberHippo]

What

Due to a recent chart change, it is not possible to disable SSL for external databases.
This change to the temporal chart allows to configure the SSL value for both internal and external databases.

Fixes airbytehq/airbyte#43328

How

By adding a new chart value to enable or disable SSL for database in the global section.

global:
  database:
    type: external
    ssl:
      enabled: false

This parameter is not related to the database type.

Note: The new value could be moved to the temporal section if needed. I thought that since the SSL flags were initially introduced in the global section I would add the new value there as well:

        #####
        # How the SSL flags were introduced
        #####

        {{- if eq .Values.global.database.type "external" }}
        # Assume an external database requires SSL.
          - name: POSTGRES_TLS_ENABLED
            value: "true"
          - name: POSTGRES_TLS_DISABLE_HOST_VERIFICATION
            value: "true"
          - name: SQL_TLS_ENABLED
            value: "true"
          - name: SQL_TLS_DISABLE_HOST_VERIFICATION
            value: "true"
        {{- end }}

Recommended reading order

1. /

Can this PR be safely reverted and rolled back?

• YES 💚 but this could break the chart as it was the case with 4731a0b
• NO ❌

[CLAassistant]

All committers have signed the CLA.

[kev-datams]

hi @davinchia, do you have an ETA ? 🙏
this is currently a blocking topic on our side to migrate to external DB without SSL
thanks 😃

[film42]

Thanks @CyberHippo for opening this. We too are broke by the previous change. Looking forward to this.

[marcosmarxm]

Hello all, sorry the delay to get review in this contribution. I raised it to the platform team. After I get a return will update here.

[kev-datams]

Hi @marcosmarxm, do you have some news about this blocking issue for us ? 🙏

[AHulshoff]

Any news on when this PR is going to be merged? It is blocking for me too. I am setting up Airbyte with Flux, so the workaround to adjust the variables will not work for me, as they will be overwritten again.

[CyberHippo]

Following the comment from @PurseChicken, do we still need this PR?

[kev-datams]

Following the comment from @PurseChicken, do we still need this PR?

Hi @CyberHippo
marking a database as internal in the YAML in order to use an external database looks confusing... I suppose the proposed solution is a temporary workaround
the ideal would be to be able to disable ssl with external as proposed in the issue 🙏

[kev-datams]

Hi @CyberHippo, do you have an ETA for the fix release ? 🙏

[CyberHippo]

Hi @kev-datams , unfortunately I am not part of Airbyte platform team and don't know about their chart release process. I am also waiting for this to be released. Maybe @davinchia knows more about it?

[marcosmarxm]

Apologies for the missing updates on this contribution. I'll coordinate with Davin to determine the next steps for securing a review.

[kev-datams]

Apologies for the missing updates on this contribution. I'll coordinate with Davin to determine the next steps for securing a review.

Thanks @marcosmarxm 🙏