Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduced protections against predictable RNG abuse #341

Closed
wants to merge 2 commits into from
Closed

Introduced protections against predictable RNG abuse #341

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
616d346
Introduced protections against predictable RNG abuse (#8)
pixeeai Jul 11, 2024
8829cf8
Merge branch 'airbytehq:main' into main
pixeeai Sep 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion airbyte-workers/src/main/java/io/airbyte/workers/helpers/ScheduleJitterHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
import io.airbyte.api.client.model.generated.ConnectionScheduleType;
import io.micronaut.context.annotation.Value;
import jakarta.inject.Singleton;
import java.security.SecureRandom;
import java.time.Duration;
import java.util.Random;
import lombok.extern.slf4j.Slf4j;
Expand Down Expand Up @@ -62,7 +63,7 @@ public Duration addJitterBasedOnWaitTime(final Duration waitTime, final Connecti
}

final int jitterSeconds;
final Random random = new Random();
final Random random = new SecureRandom();

// CRON schedules should not have negative jitter included, because then it is possible for the sync
// to start and finish before the real scheduled time. This can result in a double sync because the
Expand Down
Loading