Updated for tcp6 support. #311
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
/create-oss-pr |
## What * Makes git ignore [`jenv`](https://www.jenv.be/)'s .`.java-version` file, to avoid adding it as an unintended artifact in future commits * As of now, we do not explicitly encourage saving this file, nor do we require [`jenv`](https://www.jenv.be/) to contribute to the project, indicating that [`jenv`](https://www.jenv.be/) is the responsibility of the user, instead of the maintainer(s) ## How * Adds a rule to the project-level .gitignore file to ignore all .java-version files ## Recommended reading order 1. Related to the initial steps in [developing-locally](https://docs.airbyte.com/contributing-to-airbyte/resources/developing-locally) ## Can this PR be safely reverted and rolled back? <!-- * If you know that your be safely rolled back, check YES.* * If that is not the case (e.g. a database migration), check NO. * If unsure, leave it blank.* --> - [ x ] YES 💚 - [ ] NO ❌
|
Any update on this? This breaks ipv6 only EKS/AKS/GKE only clusters as the services cannot be contacted over ipv6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
socat only binds to TCP4 on workers.
How
socat only binds to TCP4 on worker nodes so we modify it to work with TCP6, the socat TCP6 binds to both TCP4 and TCP6 so support native IPv6 only clusters.
Recommended reading order
airbyte-commons-worker/src/main/java/io/airbyte/workers/process/KubePodProcess.javaCan this PR be safely reverted / rolled back?
If unsure, leave it blank.
🚨 User Impact 🚨
May cause issues if IPv6 routing is not configured correctly.