fix(airbyte-api): regexp for JobsController orderBy

[justenwalker]

What

The regexp for the orderBy parameter is incorrect since it is using a bare pipe character which implies an alternate expression. However, what is expected is matching a literal pipe '|' character.

Original Regexp

([a-zA-Z0-9]+)|(ASC|DESC)

The expectation is that this will match createdAt|ASC and create the following matching groups:

1. createdAt
2. ASC

However, what this regexp actually means is:

# ---- left-hand-side regexp ---
( # start capture group 1
    [a-zA-Z0-9]+ # match alphanumeric string of one or more characters
)
# ---- left-hand-side regexp ---
| # match either left-hand-side OR right-hand-side regexp
# ---- right-hand-side regexp ---
( # start capture group 2
    ASC|DESC # match the literal string `ASC` OR `DESC`
)
# ---- right-hand-side regexp ---

So it will instead produce only:

1. createdAt
2. null

Also note: the left-hand-side regexp will match anything the right-hand-side regexp could match, so that branch will never be taken. So the original regexp is functionally equivalent to ([a-zA-Z0-9]+)

How

This change adds a \ escape before the | so that the regexp matches the literal character |.

Fixed Regexp

([a-zA-Z0-9]+)\|(ASC|DESC)

This will correctly match the string createdAt|ASC as:

1. createdAt
2. ASC

Recommended reading order

1. airbyte-api-server/src/main/kotlin/io/airbyte/api/server/controllers/JobsController.kt

Can this PR be safely reverted / rolled back?

If you know that your PR is backwards-compatible and can be simply reverted or rolled back, check the YES box.

Otherwise if your PR has a breaking change, like a database migration for example, check the NO box.

If unsure, leave it blank.

• YES 💚

🚨 User Impact 🚨

No

[sonarqubecloud]

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[marcosmarxm]

Thanks @justenwalker requested to the platform team take a look in your pull request.

[JonsSpaghetti]

Good catch, thank you!

[sneakersgames]

@marcosmarxm @JonsSpaghetti When is this merge going on the main branch? We need this fix kinda urgently. 😄 Thanks!

[github-actions]

Your branch is not currently up-to-date with main. Please update your branch before attempting to snapshot your PR.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ justenwalker
❌ JonsSpaghetti
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
2.0% Duplication on New Code

See analysis details on SonarCloud

[sneakersgames]

It's stuck?

[JonsSpaghetti]

@sneakersgames Sorry for the delay on this, following up on the process for this it looks like I need to pull it into our internal repo and merge it there to make the Ci runners happy. Will do that early next week.

[github-actions]

Your branch is not currently up-to-date with main. Please update your branch before attempting to snapshot your PR.

[sneakersgames]

@JonsSpaghetti Any news on the merge?

[github-actions]

Your branch is not currently up-to-date with main. Please update your branch before attempting to snapshot your PR.

[JonsSpaghetti]

@sneakersgames this has been completed and should be present in the latest version

[github-actions]

Your branch is not currently up-to-date with main. Please update your branch before attempting to snapshot your PR.

[justenwalker]

Closing as fixed via eb2504a