Add support for private image registry #284
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a chance for user to specify an additional private image registry without change seed_sources/seed_destinations
What
How
Add registry prefix in
ProcessFactory
on create new container if the environmentJOB_KUBE_MAIN_CONTAINER_IMAGE_REGISTRY
has been assigned a valid registry string.This change was inspired and adapted from airbytehq/airbyte#16969
Recommended reading order
User Impact
This option is transparent and optional for airbyte users.
Pre-merge Checklist
Expand the relevant checklist and delete the others.