Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shareProcessNamespace to bootloader helm chart #282

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add shareProcessNamespace to bootloader helm chart #282

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
73f8976
Bootloader chart: implement shareProcessNamespace feature
sho34215 Oct 23, 2023
bba5818
Fix typo {end}
sho34215 Oct 23, 2023
e72d48f
Update comment && fix typos
sho34215 Oct 23, 2023
710ba50
Add comments
sho34215 Oct 23, 2023
b78eb31
Merge branch 'main' into main
mrhovunping Oct 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions charts/airbyte-bootloader/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ Helm chart to deploy airbyte-bootloader
| resources.limits | object | `{}` | |
| resources.requests | object | `{}` | |
| secrets | object | `{}` | |
| shareProcessNamespace | bool | `true` | |
| tolerations | list | `[]` | |

----------------------------------------------
Expand Down
3 changes: 3 additions & 0 deletions charts/airbyte-bootloader/templates/pod.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@ metadata:
{{- include "common.tplvalues.render" (dict "value" .Values.podAnnotations "context" $) | nindent 4 }}
{{- end }}
spec:
{{- if .Values.shareProcessNamespace }}
shareProcessNamespace: {{ .Values.shareProcessNamespace }}
{{- end }}
serviceAccountName: {{ .Values.global.serviceAccountName }}
{{- if .Values.global.imagePullSecrets }}
imagePullSecrets:
Expand Down
11 changes: 11 additions & 0 deletions charts/airbyte-bootloader/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ global:


enabled: true

## image.repository The repository to use for the airbyte bootloader image.
## image.pullPolicy the pull policy to use for the airbyte bootloader image
## image.tag The airbyte bootloader image tag. Defaults to the chart's AppVersion
Expand Down Expand Up @@ -124,6 +125,16 @@ extraEnv: []
## DATABASE_USER: my-db-user
secrets: {}

## In case you need to implement a sidecar pod that needs to be killed once the bootloader
## is completed. Example sidecar to connect to db (gcp auth proxy):
## Create a pod with 3 containers:
## - Bootloader container
## - Cloud SQL Auth Proxy container that creates a secured tunnel to communicate with managed GCP database
## - Additional container that scan processes to killed Cloud SQL Auth Proxy container when bootloader container is done
## If you don't have this mechanism bootloader pod will still be ready, even if bootloader container is in completed state
## because Cloud SQL Auth Proxy container is still up and airbyte deployment process will be stuck.
shareProcessNamespace: false

## extraContainer [array] Additional container for server pod(s)
## Example:
# extraContainers:
Expand Down
1 change: 1 addition & 0 deletions charts/airbyte/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ Helm chart to deploy airbyte
| airbyte-bootloader.resources.limits | object | `{}` | |
| airbyte-bootloader.resources.requests | object | `{}` | |
| airbyte-bootloader.secrets | object | `{}` | |
| airbyte-bootloader.shareProcessNamespace | bool | `true` | |
| airbyte-bootloader.tolerations | list | `[]` | |
| connector-builder-server.enabled | bool | `true` | |
| connector-builder-server.env_vars | object | `{}` | |
Expand Down
10 changes: 10 additions & 0 deletions charts/airbyte/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1048,6 +1048,16 @@ airbyte-bootloader:
## DATABASE_USER: my-db-user
secrets: {}

## In case you need to implement a sidecar pod that needs to be killed once the bootloader
## is completed. Example sidecar to connect to db (gcp auth proxy):
## Create a pod with 3 containers:
## - Bootloader container
## - Cloud SQL Auth Proxy container that creates a secured tunnel to communicate with managed GCP database
## - Additional container that scan processes to killed Cloud SQL Auth Proxy container when bootloader container is done
## If you don't have this mechanism bootloader pod will still be ready, even if bootloader container is in completed state
## because Cloud SQL Auth Proxy container is still up and airbyte deployment process will be stuck.
shareProcessNamespace: false

## env_vars [object] Supply extra env variables to main container using simplified notation
## Example:
## env_vars:
Expand Down
Loading