-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AWS SDK's sts dependency to relevant modules to fix IRSA #279
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for bringing up the changes to resolve the missing STS module!
Found other modules which are relying on |
Agreed @weichunnn, I've added this as well to |
Thanks for the continued contributions in this area @weichunnn and @sidharrth2002! I'll open this PR in our internal repo and run tests there. |
/create-oss-pr |
@sidharrth2002 @weichunnn sorry for the delay here - the internal build was failing and I didn't have time to investigate until today. Turns out there was a small issue with our PR-cloning tool and the fix was simple, so I went ahead and merged the internal PR. The changes will be reflected back to this public repo, and the fix will be available in the next OSS release. Thanks again! |
What
Add
software.amazon.awssdk:sts
dependency to potentially resolve error caused by AWSv2
SDK.The relevant error here was raised by @larrywax, relating to using IRSA credentials. Namely, this line was in the error log:
How
Airbyte's use of the AWS
v2
SDK for S3 data retrieval might require addingsoftware.amazon.awssdk:sts
due to a hardcoded class path in AWS's WebIdentityTokenCredentialsProvider causing errors.Recommended reading order
deps.toml
airbyte-commons-worker/build.gradle
airbyte-config/config-models/build.gradle
airbyte-server/build.gradle
airbyte-workers/build.gradle
Can this PR be safely reverted / rolled back?
If you know that your PR is backwards-compatible and can be simply reverted or rolled back, check the YES box.
Otherwise if your PR has a breaking change, like a database migration for example, check the NO box.
If unsure, leave it blank.
🚨 User Impact 🚨
Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.