Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add resource requests and limits to airbyte minio container #273

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
df67548
add resource requests and limits for airbyte minio container
machariamuguku Sep 17, 2023
5f13b85
Merge branch 'main' into 30509-add-minio-resources
machariamuguku Sep 19, 2023
2b0cf48
Merge branch 'main' into 30509-add-minio-resources
machariamuguku Sep 22, 2023
6a1ff5a
Merge branch 'main' into 30509-add-minio-resources
machariamuguku Sep 26, 2023
04010da
Merge branch 'main' into 30509-add-minio-resources
machariamuguku Oct 2, 2023
fcdcc6a
Merge remote-tracking branch 'origin/main' into 30509-add-minio-resou…
machariamuguku Nov 1, 2023
462ed2e
reduce formatting noise
machariamuguku Nov 1, 2023
07d2813
Merge branch 'main' into 30509-add-minio-resources
machariamuguku Nov 23, 2023
fd2957c
Merge branch 'main' into 30509-add-minio-resources
machariamuguku Dec 5, 2023
829c70c
Merge branch 'main' into 30509-add-minio-resources
machariamuguku Mar 6, 2024
b8cc981
add descriptions for added minio configs
machariamuguku Mar 6, 2024
6742ad7
fix readme table allignment
machariamuguku Mar 6, 2024
e47a7b5
Merge branch 'main' into 30509-add-minio-resources
machariamuguku Mar 7, 2024
3f3e1c3
Merge branch 'main' into 30509-add-minio-resources
machariamuguku Mar 7, 2024
190c598
Merge branch 'main' into 30509-add-minio-resources
machariamuguku Mar 11, 2024
7e703fd
Merge branch 'main' into 30509-add-minio-resources
machariamuguku Mar 22, 2024
7c54196
Adds jenv's .java-version to project .gitignore (#317)
bengineerdavis Apr 1, 2024
62170d6
Merge branch 'main' into 30509-add-minio-resources
machariamuguku Apr 2, 2024
c62e1d5
Merge branch 'main' into 30509-add-minio-resources
machariamuguku Apr 18, 2024
b279d22
Merge branch 'main' into 30509-add-minio-resources
machariamuguku Apr 29, 2024
1de36cf
Merge branch 'main' into 30509-add-minio-resources
machariamuguku Jun 28, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@ data
**/gmon.out
static_checker_reports/

# ignore jenv artifacts
.java-version

# Logs
acceptance_tests_logs/

Expand Down
2 changes: 2 additions & 0 deletions charts/airbyte/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -278,6 +278,8 @@ Helm chart to deploy airbyte
| minio.nodeSelector | object | `{}` | Node labels for pod assignment, see https://kubernetes.io/docs/user-guide/node-selection/ # |
| minio.storage.volumeClaimValue | string | `"500Mi"` | |
| minio.tolerations | list | `[]` | Tolerations for minio pod assignment, see https://kubernetes.io/docs/concepts/configuration/taint-and-toleration/ # |
| minio.resources.limits | object | `{}` | The resources limits for the minio container |
| minio.resources.requests | object | `{}` | The requested resources for the minio container |
| nameOverride | string | `""` | String to partially override airbyte.fullname template with a string (will prepend the release name) |
| pod-sweeper.affinity | object | `{}` | Affinity and anti-affinity for pod assignment, see https://kubernetes.io/docs/concepts/scheduling-eviction/assign-pod-node/#affinity-and-anti-affinity |
| pod-sweeper.containerSecurityContext.allowPrivilegeEscalation | bool | `false` | |
Expand Down
3 changes: 3 additions & 0 deletions charts/airbyte/templates/minio.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,9 @@ spec:
volumeMounts:
- name: airbyte-minio-pv-claim # must match the volume name, above
mountPath: "/storage"
{{- if .Values.minio.resources }}
resources: {{- toYaml .Values.minio.resources | nindent 12 }}
{{- end }}
{{- with .Values.minio.nodeSelector }}
nodeSelector:
{{- toYaml . | nindent 8 }}
Expand Down
19 changes: 19 additions & 0 deletions charts/airbyte/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1432,6 +1432,25 @@ minio:
# -- Affinity and anti-affinity for minio pod assignment, see
# https://kubernetes.io/docs/concepts/scheduling-eviction/assign-pod-node/#affinity-and-anti-affinity
affinity: {}
## Minio resource requests and limits
## ref: http://kubernetes.io/docs/user-guide/compute-resources/
## We usually recommend not to specify default resources and to leave this as a conscious
## choice for the user. This also increases chances charts run on environments with little
## resources, such as Minikube. If you do want to specify resources, uncomment the following
## lines, adjust them as necessary, and remove the curly braces after 'resources:'.
## minio.resources.limits [object] The resources limits for minio pod(s)
## minio.resources.requests [object] The requested resources for minio pod(s)
resources:
## Example:
## requests:
## memory: 256Mi
## cpu: 250m
requests: {}
## Example:
## limits:
## cpu: 200m
## memory: 1Gi
limits:

## @section cron parameters

Expand Down
Loading