Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm: Add ability to set resources for postgresql and minio deployments #270

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion charts/airbyte/templates/airbyte-db.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,8 @@ spec:
volumeMounts:
- name: airbyte-volume-db
mountPath: /var/lib/postgresql/data
resources:
{{- toYaml .Values.postgresql.resources | nindent 12 }}
volumeClaimTemplates:
- metadata:
name: airbyte-volume-db
Expand All @@ -61,4 +63,4 @@ spec:
resources:
requests:
storage: 500Mi
{{- end }}
{{- end }}
2 changes: 2 additions & 0 deletions charts/airbyte/templates/minio.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,8 @@ spec:
volumeMounts:
- name: airbyte-minio-pv-claim # must match the volume name, above
mountPath: "/data"
resources:
{{- toYaml .Values.minio.resources | nindent 12 }}
{{- with .Values.minio.nodeSelector }}
nodeSelector:
{{- toYaml . | nindent 8 }}
Expand Down
40 changes: 40 additions & 0 deletions charts/airbyte/values.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
### TEST FOR RELEASE WORKFLOW

## @section Global Parameters
Expand Down Expand Up @@ -1248,6 +1249,8 @@ temporal:
## postgresql.containerSecurityContext.runAsNonRoot Ensures the container will run with a non-root user
## postgresql.commonAnnotations.helm.sh/hook It will determine when the hook should be rendered
## postgresql.commonAnnotations.helm.sh/hook-weight The order in which the hooks are executed. If weight is lower, it has higher priority
## postgresql.resources.limits [object] The resources limits for postgresql
## postgresql.resources.requests [object] The requested resources for postgresql
##
postgresql:
enabled: true
Expand All @@ -1268,6 +1271,23 @@ postgresql:
commonAnnotations:
helm.sh/hook: pre-install,pre-upgrade
helm.sh/hook-weight: "-1"

## PostgreSQL resource requests and limits
## ref: http://kubernetes.io/docs/user-guide/compute-resources/
## We usually recommend not to specify default resources and to leave this as a conscious
## choice for the user. This also increases chances charts run on environments with little
## resources, such as Minikube. If you do want to specify resources, uncomment the following
## lines, adjust them as necessary, and remove the curly braces after 'resources:'.
## postgresql.resources.limits [object] The resources limits for postgresql
## postgresql.resources.requests [object] The requested resources for postgresql
resources: {}
# limits:
# cpu: 100m
# memory: 128Mi
# requests:
# cpu: 100m
# memory: 128Mi

## External PostgreSQL configuration
## All of these values are only used when postgresql.enabled is set to false
## externalDatabase.host Database host
Expand All @@ -1289,11 +1309,14 @@ externalDatabase:
port: 5432
jdbcUrl: ""


## @section Logs parameters

## @section Minio chart overwrites
## minio.accessKey.password Minio Access Key
## minio.secretKey.password Minio Secret Key
## minio.resources.limits [object] The resources limits for minio
## minio.resources.requests [object] The requested resources for minio
minio:
enabled: true

Expand All @@ -1309,6 +1332,23 @@ minio:
storage:
volumeClaimValue: 500Mi


## Minio resource requests and limits
## ref: http://kubernetes.io/docs/user-guide/compute-resources/
## We usually recommend not to specify default resources and to leave this as a conscious
## choice for the user. This also increases chances charts run on environments with little
## resources, such as Minikube. If you do want to specify resources, uncomment the following
## lines, adjust them as necessary, and remove the curly braces after 'resources:'.
## minio.resources.limits [object] The resources limits for minio
## minio.resources.requests [object] The requested resources for minio
resources: {}
# limits:
# cpu: 100m
# memory: 128Mi
# requests:
# cpu: 100m
# memory: 128Mi

## @section cron parameters

cron:
Expand Down