Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASRE-550: Fix WORKLOAD_API_BEARER_TOKEN issue #376

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sho-equativ
Copy link

What

This change updates the WORKLOAD_API_BEARER_TOKEN to use a dynamic value by referencing bearerToken in the workload-api and workload-api-server sections from the Helm values file.

How

This modification uses Helm's index function to dynamically fetch the bearerToken values from .Values.workload-api and .Values.workload-api-server, ensuring that the correct token is used for authentication. The tokens are now quoted properly for use in Kubernetes configurations.

Before:
WORKLOAD_API_BEARER_TOKEN: {{ index ".Values.workload-api.bearerToken" | quote }}
After:
WORKLOAD_API_BEARER_TOKEN: {{ index .Values "workload-api-server" "bearerToken" | quote }}

Can this PR be safely reverted and rolled back?

  • [X ] YES 💚
  • NO ❌

@CLAassistant
Copy link

CLAassistant commented Dec 6, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ sho-equativ
❌ sho34215
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants