add resource requests and limits for airbyte minio container

airbytehq · Sep 17, 2023 · df67548 · df67548
1 parent 3c9c2ed
commit df67548
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 0 deletions.
diff --git a/charts/airbyte/README.md b/charts/airbyte/README.md
@@ -152,6 +152,8 @@ Helm chart to deploy airbyte
 | minio.image.repository | string | `"minio/minio"`                      |  |
 | minio.image.tag | string | `"latest"`                           |  |
 | minio.storage.volumeClaimValue | string | `500Mi`                              |  |
+| minio.resources.limits | object | `{}`                                 |  |
+| minio.resources.requests | object | `{}`                                 |  |
 | nameOverride | string | `""`                                 |  |
 | pod-sweeper.affinity | object | `{}`                                 |  |
 | pod-sweeper.containerSecurityContext | object | `{}`                                 |  |

diff --git a/charts/airbyte/templates/minio.yaml b/charts/airbyte/templates/minio.yaml
@@ -48,6 +48,9 @@ spec:
           volumeMounts:
             - name: airbyte-minio-pv-claim # must match the volume name, above
               mountPath: "/data"
+          {{- if .Values.minio.resources }}
+          resources: {{- toYaml .Values.minio.resources | nindent 12 }}
+          {{- end }}
       {{- with .Values.minio.nodeSelector }}
       nodeSelector:
         {{- toYaml . | nindent 8 }}

diff --git a/charts/airbyte/values.yaml b/charts/airbyte/values.yaml
@@ -1308,6 +1308,26 @@ minio:
   storage:
     volumeClaimValue: 500Mi
 
+  ## Minio resource requests and limits
+  ## ref: http://kubernetes.io/docs/user-guide/compute-resources/
+  ## We usually recommend not to specify default resources and to leave this as a conscious
+  ## choice for the user. This also increases chances charts run on environments with little
+  ## resources, such as Minikube. If you do want to specify resources, uncomment the following
+  ## lines, adjust them as necessary, and remove the curly braces after 'resources:'.
+  ##  minio.resources.limits [object] The resources limits for minio pod(s)
+  ##  minio.resources.requests [object] The requested resources for minio pod(s)
+  resources:
+    ## Example:
+    ## requests:
+    ##    memory: 256Mi
+    ##    cpu: 250m
+    requests: {}
+    ## Example:
+    ## limits:
+    ##    cpu: 200m
+    ##    memory: 1Gi
+    limits: {}
+
 ## @section cron parameters
 
 cron: