refactor: add previosVersionDockerImageTag to connector rollout start…

… input (#14632) Co-authored-by: Pedro S. Lopez <[email protected]>
airbytehq · Nov 16, 2024 · 729ba94 · 729ba94
1 parent f103b4d
commit 729ba94
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 0 deletions.
diff --git a/...mons-server/src/main/kotlin/io/airbyte/commons/server/handlers/ConnectorRolloutHandler.kt b/...mons-server/src/main/kotlin/io/airbyte/commons/server/handlers/ConnectorRolloutHandler.kt
@@ -473,6 +473,7 @@ open class ConnectorRolloutHandler
             rollout.id,
             connectorRolloutWorkflowStart.updatedBy,
             rollout.rolloutStrategy,
+            actorDefinitionService.getActorDefinitionVersion(rollout.initialVersionId).dockerImageTag,
             rollout,
           ),
         )
@@ -497,6 +498,7 @@ open class ConnectorRolloutHandler
               connectorRolloutUpdate.id,
               connectorRolloutUpdate.updatedBy,
               getRolloutStrategyForManualUpdate(connectorRollout.rolloutStrategy),
+              actorDefinitionService.getActorDefinitionVersion(connectorRollout.initialVersionId).dockerImageTag,
               connectorRollout,
             ),
           )
@@ -538,6 +540,7 @@ open class ConnectorRolloutHandler
               connectorRolloutFinalize.id,
               connectorRolloutFinalize.updatedBy,
               getRolloutStrategyForManualUpdate(connectorRollout.rolloutStrategy),
+              actorDefinitionService.getActorDefinitionVersion(connectorRollout.initialVersionId).dockerImageTag,
               connectorRollout,
             ),
           )

diff --git a/...n/kotlin/io/airbyte/connector/rollout/shared/models/ConnectorRolloutActivityInputStart.kt b/...n/kotlin/io/airbyte/connector/rollout/shared/models/ConnectorRolloutActivityInputStart.kt
@@ -11,5 +11,6 @@ data class ConnectorRolloutActivityInputStart(
   var rolloutId: UUID,
   var updatedBy: UUID? = null,
   var rolloutStrategy: ConnectorEnumRolloutStrategy? = null,
+  var initialVersionDockerImageTag: String? = null,
   var connectorRollout: ConnectorRollout? = null,
 )
diff --git a/...r/src/test/kotlin/io/airbyte/connector/rollout/worker/ConnectorRolloutWorkflowImplTest.kt b/...r/src/test/kotlin/io/airbyte/connector/rollout/worker/ConnectorRolloutWorkflowImplTest.kt
@@ -155,6 +155,7 @@ class ConnectorRolloutWorkflowImplTest {
         USER_ID,
         ROLLOUT_STRATEGY,
         null,
+        null,
       ),
     )
   }
-Original file line number
+Diff line change
@@ Expand Up / @@ -155,6 +155,7 @@ class ConnectorRolloutWorkflowImplTest { @@
             USER_ID,
             ROLLOUT_STRATEGY,
             null,
+            null,
           ),
         )
       }
@@ Expand Down @@