Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nil analytics_id/anonymous_user_id causing panics #48

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

colesnodgrass
Copy link
Member

  • fix Error when running abctl local install on Mac arm airbyte#40745
  • verify the analytics configuration keys analytics_id and anonymous_user_id are strings
    • Prior to this fix, if the keys analytics_id or anonymous_user_id existed in the analytics.yml file without a value (analytics_id:), the code would incorrectly assume that a valid key also meant a valid value and would panic if this turned out to not be the case.
  • add two tests to also verify the panic existing behavior and fixed new behavior

@colesnodgrass colesnodgrass requested a review from perangel July 15, 2024 21:50
@colesnodgrass colesnodgrass merged commit 7136efd into main Jul 15, 2024
2 checks passed
@colesnodgrass colesnodgrass deleted the cole/fix-40745 branch July 15, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when running abctl local install on Mac arm
2 participants