chore: replace global variables with Config struct
#26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perangel
reviewed
May 14, 2024
| } | ||
| printProviderDetails(provider) | ||
| printProviderDetails(cfg.Provider) |
There was a problem hiding this comment.
This is where I find it useful to have a singleton Config struct, which can be constructed at the root command (or the root of the command subtree that makes use of those configs), as opposed to threading it through to all of these subcommand constructors.
I also thing its a little odd to take a config struct here, modify it by assigning the TelClient and then passing that along. So I would suggest assigning TelClient in the caller (parent command)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.